Re: [PATCH 03/13] oslib-posix: default exec_dir to bindir

2020-09-01 Thread Paolo Bonzini
On 01/09/20 20:04, Richard Henderson wrote: > On 8/31/20 11:20 PM, Paolo Bonzini wrote: >> +exec_dir = g_strdup(CONFIG_BINDIR); > > Why the strdup? The string constant should be fine, IIUC. Of course it is. Paolo

Re: [PATCH 03/13] oslib-posix: default exec_dir to bindir

2020-09-01 Thread Richard Henderson
On 8/31/20 11:20 PM, Paolo Bonzini wrote: > +exec_dir = g_strdup(CONFIG_BINDIR); Why the strdup? The string constant should be fine, IIUC. r~

[PATCH 03/13] oslib-posix: default exec_dir to bindir

2020-08-31 Thread Paolo Bonzini
If the exec_dir cannot be retrieved, just assume it's the installation directory that was specified at configure time. This makes it simpler to reason about what the callers will do if they get back an empty path. Signed-off-by: Paolo Bonzini --- meson.build| 2 +- util/oslib-posix.c |