Re: [PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors

2020-04-28 Thread Markus Armbruster
oject.org >> Subject: [PATCH 02/11] xen: Fix and improve handling of device_add usb-host >> errors >> >> usbback_portid_add() leaks the error when qdev_device_add() fails. >> Fix that. While there, use the error to improve the error message. >> >> The qem

RE: [PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors

2020-04-27 Thread Paul Durrant
> -Original Message- > From: Markus Armbruster > Sent: 24 April 2020 20:20 > To: qemu-devel@nongnu.org > Cc: Stefano Stabellini ; Anthony Perard > ; Paul > Durrant ; Gerd Hoffmann ; > xen-de...@lists.xenproject.org > Subject: [PATCH 02/11] xen: Fix and improve

[PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors

2020-04-24 Thread Markus Armbruster
usbback_portid_add() leaks the error when qdev_device_add() fails. Fix that. While there, use the error to improve the error message. The qemu_opts_from_qdict() similarly leaks on failure. But any failure there is a programming error. Pass &error_abort. Fixes: 816ac92ef769f9ffc534e49a1bb6177bd