Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-21 Thread Alessandro Di Federico via
On Mon, 20 Mar 2023 10:10:27 + Alex Bennée wrote: > This doesn't save much as cpu-exec-common still needs to be built > per-target for its knowledge of CPUState but this helps with keeping > things organised. > --- /dev/null > +++ b/accel/tcg/cpu-exec-softmmu.c Could `cpu_reloading_memory_m

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Richard Henderson
On 3/20/23 07:33, Alex Bennée wrote: Claudio Fontana writes: On 3/20/23 14:32, Alex Bennée wrote: Claudio Fontana writes: How is this conditional on CONFIG_TCG? To me it looks like this breaks !CONFIG_TCG. Careful, the meson.build in accel/tcg/meson.build is always recursed. Surely it

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Alex Bennée
Claudio Fontana writes: > On 3/20/23 14:32, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> How is this conditional on CONFIG_TCG? To me it looks like this breaks >>> !CONFIG_TCG. >>> Careful, the meson.build in accel/tcg/meson.build is always recursed. >> >> Surely it shouldn't be

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Claudio Fontana
On 3/20/23 14:32, Alex Bennée wrote: > > Claudio Fontana writes: > >> How is this conditional on CONFIG_TCG? To me it looks like this breaks >> !CONFIG_TCG. >> Careful, the meson.build in accel/tcg/meson.build is always recursed. > > Surely it shouldn't be in accel/tcg then? Hi Alex, maybe

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Alex Bennée
Claudio Fontana writes: > How is this conditional on CONFIG_TCG? To me it looks like this breaks > !CONFIG_TCG. > Careful, the meson.build in accel/tcg/meson.build is always recursed. Surely it shouldn't be in accel/tcg then? > This code was in tcg_ss before, why not simply add it to tcg_ss

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Claudio Fontana
How is this conditional on CONFIG_TCG? To me it looks like this breaks !CONFIG_TCG. Careful, the meson.build in accel/tcg/meson.build is always recursed. This code was in tcg_ss before, why not simply add it to tcg_ss and then to specific_ss along with the other tcg pieces? Ciao, C On 3/20/2

[PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Alex Bennée
This doesn't save much as cpu-exec-common still needs to be built per-target for its knowledge of CPUState but this helps with keeping things organised. Signed-off-by: Alex Bennée --- accel/tcg/cpu-exec-common.c | 30 -- accel/tcg/cpu-exec-softmmu.c | 50