Re: [PATCH 01/23] docs/qapidoc: support header-less freeform sections

2025-01-14 Thread Markus Armbruster
John Snow writes: > On Mon, Dec 16, 2024 at 8:15 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > The code as written can't handle if a header isn't found, because `node` >> > will be uninitialized. >> >> Yes, we initialize @node only if we have a heading. >> >> Made me wonder what ha

Re: [PATCH 01/23] docs/qapidoc: support header-less freeform sections

2025-01-13 Thread John Snow
On Mon, Dec 16, 2024 at 8:15 AM Markus Armbruster wrote: > John Snow writes: > > > The code as written can't handle if a header isn't found, because `node` > > will be uninitialized. > > Yes, we initialize @node only if we have a heading. > > Made me wonder what happens when we don't. So I dele

Re: [PATCH 01/23] docs/qapidoc: support header-less freeform sections

2024-12-16 Thread Markus Armbruster
John Snow writes: > The code as written can't handle if a header isn't found, because `node` > will be uninitialized. Yes, we initialize @node only if we have a heading. Made me wonder what happens when we don't. So I deleted the = from the "# = Subsection" line in doc-good.json, and got:

[PATCH 01/23] docs/qapidoc: support header-less freeform sections

2024-12-12 Thread John Snow
The code as written can't handle if a header isn't found, because `node` will be uninitialized. If we don't have a section title, create a generic block to insert text into instead. This patch removes a lingering pylint warning in the QAPIDoc implementation that prevents getting a clean baseline t