Re: [PATCH 01/22] semihosting: fix order of initialization functions

2020-10-27 Thread Paolo Bonzini
On 27/10/20 12:18, Alex Bennée wrote: >> >> -/* now chardevs have been created we may have semihosting to connect */ >> -qemu_semihosting_connect_chardevs(); >> - > Move both here: > > if (foreach_device_config(DEV_DEBUGCON, debugcon_parse) < 0) > exit(1); > > /* now cha

Re: [PATCH 01/22] semihosting: fix order of initialization functions

2020-10-27 Thread Alex Bennée
Paolo Bonzini writes: > qemu_semihosting_console_init uses semihosting.chardev which is set > by qemu_semihosting_connect_chardevs. Thus qemu_semihosting_connect_chardevs > has to be called first. It looks like this is reverting 619985e9 ("semihosting: defer connect_chardevs a little more to

[PATCH 01/22] semihosting: fix order of initialization functions

2020-10-21 Thread Paolo Bonzini
qemu_semihosting_console_init uses semihosting.chardev which is set by qemu_semihosting_connect_chardevs. Thus qemu_semihosting_connect_chardevs has to be called first. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/softmm