Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-27 Thread Markus Armbruster
John Snow writes: > On 4/27/21 9:47 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 4/23/21 11:46 AM, Markus Armbruster wrote: John Snow writes: > The short-ish version of what motivates this patch is: > > - The parser initializer does not possess adequate con

Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-27 Thread John Snow
On 4/27/21 9:47 AM, Markus Armbruster wrote: John Snow writes: On 4/23/21 11:46 AM, Markus Armbruster wrote: John Snow writes: The short-ish version of what motivates this patch is: - The parser initializer does not possess adequate context to write a good error message -- It tries to

Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-27 Thread Markus Armbruster
John Snow writes: > On 4/23/21 11:46 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> The short-ish version of what motivates this patch is: >>> >>> - The parser initializer does not possess adequate context to write a >>>good error message -- It tries to determine the caller's sema

Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-23 Thread John Snow
On 4/23/21 11:46 AM, Markus Armbruster wrote: John Snow writes: The short-ish version of what motivates this patch is: - The parser initializer does not possess adequate context to write a good error message -- It tries to determine the caller's semantic context. I'm not sure I get wh

Re: [PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-23 Thread Markus Armbruster
John Snow writes: > The short-ish version of what motivates this patch is: > > - The parser initializer does not possess adequate context to write a > good error message -- It tries to determine the caller's semantic > context. I'm not sure I get what you're trying to say here. > - We don't

[PATCH 01/22] qapi/parser: Don't try to handle file errors

2021-04-21 Thread John Snow
The short-ish version of what motivates this patch is: - The parser initializer does not possess adequate context to write a good error message -- It tries to determine the caller's semantic context. - We don't want to allow QAPISourceInfo(None, None, None) to exist. - Errors made using such a