Re: [PATCH 01/19] hw/arm/raspi: Use the IEC binary prefix definitions

2019-10-08 Thread Cleber Rosa
On Thu, Sep 26, 2019 at 07:34:09PM +0200, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/raspi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/raspi.c b/hw

Re: [PATCH 01/19] hw/arm/raspi: Use the IEC binary prefix definitions

2019-10-08 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > hw/arm/raspi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/raspi.c b/hw/arm/raspi.

Re: [PATCH 01/19] hw/arm/raspi: Use the IEC binary prefix definitions

2019-09-27 Thread Alistair Francis
On Thu, Sep 26, 2019 at 10:36 AM Philippe Mathieu-Daudé wrote: > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/raspi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

[PATCH 01/19] hw/arm/raspi: Use the IEC binary prefix definitions

2019-09-26 Thread Philippe Mathieu-Daudé
IEC binary prefixes ease code review: the unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 74c062d05e..615d755879 100644 --- a/hw/arm/raspi.c +++ b/hw/arm/raspi