Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-02-01 Thread Jason Gunthorpe
On Wed, Feb 01, 2023 at 11:42:46AM -0700, Alex Williamson wrote: > > 'p2p off' is a valuable option in its own right because this stuff > > doesn't work reliably and is actively dangerous. Did you know you can > > hard crash the bare metal from a guest on some platforms with P2P > > operations? Yi

Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-02-01 Thread Alex Williamson
On Wed, 1 Feb 2023 13:28:40 -0400 Jason Gunthorpe wrote: > On Tue, Jan 31, 2023 at 09:15:03PM -0700, Alex Williamson wrote: > > > > IMHO this is generally the way forward to do multi-device as well, > > > remove the MMIO from all the address maps: VFIO, SW access, all of > > > them. Nothing can

Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-02-01 Thread Jason Gunthorpe
On Tue, Jan 31, 2023 at 09:15:03PM -0700, Alex Williamson wrote: > > IMHO this is generally the way forward to do multi-device as well, > > remove the MMIO from all the address maps: VFIO, SW access, all of > > them. Nothing can touch MMIO except for the vCPU. > > Are you suggesting this relative

Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-01-31 Thread Alex Williamson
On Tue, 31 Jan 2023 19:29:48 -0400 Jason Gunthorpe wrote: > On Tue, Jan 31, 2023 at 03:43:01PM -0700, Alex Williamson wrote: > > > How does this affect our path towards supported migration? I'm > > thinking about a user experience where QEMU supports migration if > > device A OR device B are at

Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-01-31 Thread Jason Gunthorpe
On Tue, Jan 31, 2023 at 03:43:01PM -0700, Alex Williamson wrote: > How does this affect our path towards supported migration? I'm > thinking about a user experience where QEMU supports migration if > device A OR device B are attached, but not devices A and B attached to > the same VM. We might h

Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-01-31 Thread Alex Williamson
On Tue, 31 Jan 2023 14:44:54 +0200 Avihai Horon wrote: > On 27/01/2023 1:52, Alex Williamson wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, 26 Jan 2023 20:49:31 +0200 > > Avihai Horon wrote: > > > >> Pre-copy support allows the VFIO device data to be tr

Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-01-31 Thread Avihai Horon
On 27/01/2023 1:52, Alex Williamson wrote: External email: Use caution opening links or attachments On Thu, 26 Jan 2023 20:49:31 +0200 Avihai Horon wrote: Pre-copy support allows the VFIO device data to be transferred while the VM is running. This helps to accommodate VFIO devices that hav

Re: [PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-01-26 Thread Alex Williamson
On Thu, 26 Jan 2023 20:49:31 +0200 Avihai Horon wrote: > Pre-copy support allows the VFIO device data to be transferred while the > VM is running. This helps to accommodate VFIO devices that have a large > amount of data that needs to be transferred, and it can reduce migration > downtime. > > P

[PATCH 01/18] vfio/migration: Add VFIO migration pre-copy support

2023-01-26 Thread Avihai Horon
Pre-copy support allows the VFIO device data to be transferred while the VM is running. This helps to accommodate VFIO devices that have a large amount of data that needs to be transferred, and it can reduce migration downtime. Pre-copy support is optional in VFIO migration protocol v2. Implement