Re: [PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-12 Thread Avihai Horon
On 12/02/2024 16:49, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 2/12/24 09:36, Avihai Horon wrote: Hi, Cedric On 07/02/2024 15:33, Cédric Le Goater wrote: External email: Use caution opening links or attachments The purpose is to record a potentia

Re: [PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-12 Thread Cédric Le Goater
On 2/12/24 09:36, Avihai Horon wrote: Hi, Cedric On 07/02/2024 15:33, Cédric Le Goater wrote: External email: Use caution opening links or attachments The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handl

Re: [PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-12 Thread Avihai Horon
Hi, Cedric On 07/02/2024 15:33, Cédric Le Goater wrote: External email: Use caution opening links or attachments The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error ar

Re: [PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-08 Thread Cédric Le Goater
On 2/7/24 21:11, Philippe Mathieu-Daudé wrote: On 7/2/24 14:33, Cédric Le Goater wrote: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing

Re: [PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-07 Thread Peter Xu
On Wed, Feb 07, 2024 at 02:33:34PM +0100, Cédric Le Goater wrote: > diff --git a/migration/ram.c b/migration/ram.c > index > d5b7cd5ac2f31aabf4a248b966153401c48912cf..136c237f4079f68d4e578cf1c72eec2efc815bc8 > 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -2931,7 +2931,7 @@ void qem

Re: [PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-07 Thread Philippe Mathieu-Daudé
On 7/2/24 14:33, Cédric Le Goater wrote: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and calling locally error_report(). Th

[PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-07 Thread Cédric Le Goater
The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and calling locally error_report(). The following patches will introduce such cha