Re: [PATCH 01/13] linux-user: Add missing signals in strace output

2022-08-28 Thread Richard Henderson
On 8/26/22 07:18, Helge Deller wrote: Some of the guest signal numbers are currently not converted to their representative names in the strace output, e.g. SIGVTALRM. This patch introduces a smart way to generate and keep in sync the host-to-guest and guest-to-host signal conversion tables for u

Re: [PATCH 01/13] linux-user: Add missing signals in strace output

2022-08-26 Thread Helge Deller
* Richard Henderson : > On 8/26/22 07:18, Helge Deller wrote: > > +if (arg < _NSIG) > > +signal_name = target_signal_to_host_signal_table[arg]; > (1) static const char * const > (2) target_signal_name -- there's no "host" about this. > Oh, and _NSIG is a host thing. Leave the array a

Re: [PATCH 01/13] linux-user: Add missing signals in strace output

2022-08-26 Thread Richard Henderson
On 8/26/22 07:18, Helge Deller wrote: +if (arg < _NSIG) +signal_name = target_signal_to_host_signal_table[arg]; Oh, and _NSIG is a host thing. Leave the array as [] and then bound the lookup with ARRAY_SIZE(target_signal_name). Also, missing {}. r~

Re: [PATCH 01/13] linux-user: Add missing signals in strace output

2022-08-26 Thread Richard Henderson
On 8/26/22 07:18, Helge Deller wrote: +static const char *target_signal_to_host_signal_table[_NSIG] = { (1) static const char * const (2) target_signal_name -- there's no "host" about this. r~

[PATCH 01/13] linux-user: Add missing signals in strace output

2022-08-26 Thread Helge Deller
Some of the guest signal numbers are currently not converted to their representative names in the strace output, e.g. SIGVTALRM. This patch introduces a smart way to generate and keep in sync the host-to-guest and guest-to-host signal conversion tables for usage in the qemu signal and strace code.