Re: [PATCH 01/11] nbd/server: Remove unused variable

2021-07-13 Thread Richard Henderson
On 7/13/21 6:14 AM, Eric Blake wrote: Hmm; in glib 2.68.2 (on Fedora 34), g_autofree does NOT include an attribute unused. Thus, does this silence the compiler? (Even cooler would be making the comment a link to an actual bug in the clang database, but I couldn't quickly find one) diff --git i

Re: [PATCH 01/11] nbd/server: Remove unused variable

2021-07-13 Thread Eric Blake
On Tue, Jul 13, 2021 at 08:01:34AM -0500, Eric Blake wrote: > > > @@ -973,7 +973,6 @@ static int nbd_negotiate_meta_queries(NBDClient > > > *client, > > > { > > > int ret; > > > g_autofree char *export_name = NULL; > > > -g_autofree bool *bitmaps = NULL; > > > NBDExportMeta

Re: [PATCH 01/11] nbd/server: Remove unused variable

2021-07-13 Thread Eric Blake
On Tue, Jul 13, 2021 at 12:27:48PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 13.07.2021 00:55, Richard Henderson wrote: > > From clang-13: > > nbd/server.c:976:22: error: variable 'bitmaps' set but not used \ > > [-Werror,-Wunused-but-set-variable] > > > > +++ b/nbd/server.c > > @@ -973,

Re: [PATCH 01/11] nbd/server: Remove unused variable

2021-07-13 Thread Vladimir Sementsov-Ogievskiy
13.07.2021 00:55, Richard Henderson wrote: From clang-13: nbd/server.c:976:22: error: variable 'bitmaps' set but not used \ [-Werror,-Wunused-but-set-variable] Cc: qemu-bl...@nongnu.org Cc: Eric Blake Cc: Vladimir Sementsov-Ogievskiy Signed-off-by: Richard Henderson --- nbd/server.c |

[PATCH 01/11] nbd/server: Remove unused variable

2021-07-12 Thread Richard Henderson
>From clang-13: nbd/server.c:976:22: error: variable 'bitmaps' set but not used \ [-Werror,-Wunused-but-set-variable] Cc: qemu-bl...@nongnu.org Cc: Eric Blake Cc: Vladimir Sementsov-Ogievskiy Signed-off-by: Richard Henderson --- nbd/server.c | 4 1 file changed, 4 deletions(-) diff -