Il lun 14 set 2020, 18:23 Richard Henderson
ha scritto:
> Do we really need to keep testing $source/.git and $git_update?
> Surely we can accumulate git_submodules and then do (or not do) something
> with
> that at the end without all of the tests?
>
Possibly, but I don't mind going through that
On 9/14/20 6:28 AM, Paolo Bonzini wrote:
> We can simplify it further if we move the selection logic to
> meson.build. Here in configure the whole capstone stanza
> is replaced by
>
> capstone=auto
> ...
> case "$capstone" in
> auto|git)
> # Simpler to always update submodule, even if not n
On Mon, 14 Sep 2020 at 01:04, Richard Henderson
wrote:
>
> There are better ways to do this, e.g. meson cmake subproject,
> but that requires cmake 3.7 and some of our CI environments
> only provide cmake 3.5.
>
> Nor can we add a meson.build file to capstone/, because the git
> submodule would th
On 14/09/20 02:01, Richard Henderson wrote:
>
> case "$capstone" in
> - git | internal)
> + git)
> if test "$capstone" = git; then
>git_submodules="${git_submodules} capstone"
> fi
> -mkdir -p capstone
> -if test "$mingw32" = "yes"; then
> - LIBCAPSTONE=capstone.l
On 9/13/20 5:01 PM, Richard Henderson wrote:
> case "$capstone" in
> - git | internal)
> + git)
> if test "$capstone" = git; then
>git_submodules="${git_submodules} capstone"
> fi
The if here can be removed now. Alternately...
> -mkdir -p capstone
> -if test "$mingw3
There are better ways to do this, e.g. meson cmake subproject,
but that requires cmake 3.7 and some of our CI environments
only provide cmake 3.5.
Nor can we add a meson.build file to capstone/, because the git
submodule would then always report "untracked files". Fixing that
would require creati
