Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-09 Thread Aleksandar Markovic
On Thursday, February 6, 2020, Peter Maydell wrote: > > > This series switches all our QAPI doc > > > comments over from > > texinfo format to rST. > > Regardeless of the outcome of the discussions over this series, I just want to say that I support it as a potential user of the document (there i

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-08 Thread Peter Maydell
On Sat, 8 Feb 2020 at 14:16, Markus Armbruster wrote: > I understand the difficulty of parsing rST (Paolo called it "the Perl of > markup languages" for a reason). What I don't yet understand is (1) why > we need to recognize the document structure of doc comments, and (2) why > we can do that by

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-08 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 7 Feb 2020 at 17:00, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > This series switches all our QAPI doc comments over from >> > texinfo format to rST. >> > >> > The basic approach is somewhat similar to how we deal with kerneldoc >> > and hxtool:

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 17:00, Markus Armbruster wrote: > > Peter Maydell writes: > > > This series switches all our QAPI doc comments over from > > texinfo format to rST. > > > > The basic approach is somewhat similar to how we deal with kerneldoc > > and hxtool: we have a custom Sphinx extension

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > This series switches all our QAPI doc comments over from > texinfo format to rST. > > The basic approach is somewhat similar to how we deal with kerneldoc > and hxtool: we have a custom Sphinx extension which is passed a > filename which is the json file it should run the

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200206173040.17337-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200206173040.17337-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-06 Thread Peter Maydell
On Thu, 6 Feb 2020 at 17:30, Peter Maydell wrote: > This series switches all our QAPI doc comments over from > texinfo format to rST. Oops, this fails 'make check' because I forgot to run it (not thinking of docs changes as being stuff that affects test) and there are a couple of golden-master fi

[PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-06 Thread Peter Maydell
This series switches all our QAPI doc comments over from texinfo format to rST. The basic approach is somewhat similar to how we deal with kerneldoc and hxtool: we have a custom Sphinx extension which is passed a filename which is the json file it should run the QAPI parser over and generate doc