Re: [PATCH 0/7] python: create installable package

2020-06-19 Thread John Snow
On 6/19/20 12:44 PM, Kevin Wolf wrote: > Am 19.06.2020 um 17:04 hat John Snow geschrieben: >> On 6/18/20 5:23 AM, Kevin Wolf wrote: >>> Am 17.06.2020 um 22:27 hat John Snow geschrieben: > In the Avocado project, we have a `make develop` rule that does that > for the main setup.py file, a

Re: [PATCH 0/7] python: create installable package

2020-06-19 Thread Kevin Wolf
Am 19.06.2020 um 17:04 hat John Snow geschrieben: > On 6/18/20 5:23 AM, Kevin Wolf wrote: > > Am 17.06.2020 um 22:27 hat John Snow geschrieben: > >>> In the Avocado project, we have a `make develop` rule that does that > >>> for the main setup.py file, and for all plugins we carry on the same > >>>

Re: [PATCH 0/7] python: create installable package

2020-06-19 Thread John Snow
On 6/19/20 11:15 AM, Philippe Mathieu-Daudé wrote: > On 6/17/20 10:27 PM, John Snow wrote: >> >> >> On 6/17/20 3:52 PM, Cleber Rosa wrote: >>> On Tue, Jun 02, 2020 at 08:15:16PM -0400, John Snow wrote: > [...] >>> Are you proposing that we have, say, "python-qemu" version 10, being >>> the 10th

Re: [PATCH 0/7] python: create installable package

2020-06-19 Thread Philippe Mathieu-Daudé
On 6/17/20 10:27 PM, John Snow wrote: > > > On 6/17/20 3:52 PM, Cleber Rosa wrote: >> On Tue, Jun 02, 2020 at 08:15:16PM -0400, John Snow wrote: [...] >> Are you proposing that we have, say, "python-qemu" version 10, being >> the 10th API version, without any regard to the QEMU version >> support

Re: [PATCH 0/7] python: create installable package

2020-06-19 Thread Philippe Mathieu-Daudé
On 6/18/20 11:23 AM, Kevin Wolf wrote: > Am 17.06.2020 um 22:27 hat John Snow geschrieben: >>> In the Avocado project, we have a `make develop` rule that does that >>> for the main setup.py file, and for all plugins we carry on the same >>> tree, which is similar in some regards to the "not at the

Re: [PATCH 0/7] python: create installable package

2020-06-19 Thread John Snow
On 6/18/20 5:23 AM, Kevin Wolf wrote: > Am 17.06.2020 um 22:27 hat John Snow geschrieben: >>> In the Avocado project, we have a `make develop` rule that does that >>> for the main setup.py file, and for all plugins we carry on the same >>> tree, which is similar in some regards to the "not at th

Re: [PATCH 0/7] python: create installable package

2020-06-18 Thread Kevin Wolf
Am 17.06.2020 um 22:27 hat John Snow geschrieben: > > In the Avocado project, we have a `make develop` rule that does that > > for the main setup.py file, and for all plugins we carry on the same > > tree, which is similar in some regards to the "not at the project root > > directory" situation her

Re: [PATCH 0/7] python: create installable package

2020-06-17 Thread John Snow
On 6/17/20 3:52 PM, Cleber Rosa wrote: > On Tue, Jun 02, 2020 at 08:15:16PM -0400, John Snow wrote: >> Based-on: 20200602214528.12107-1-js...@redhat.com >> >> This series factors the python/qemu directory as an installable >> module. As a developer, you can install this to your virtual environme

Re: [PATCH 0/7] python: create installable package

2020-06-17 Thread Cleber Rosa
On Tue, Jun 02, 2020 at 08:15:16PM -0400, John Snow wrote: > Based-on: 20200602214528.12107-1-js...@redhat.com > > This series factors the python/qemu directory as an installable > module. As a developer, you can install this to your virtual environment > and then always have access to the classes

Re: [PATCH 0/7] python: create installable package

2020-06-08 Thread John Snow
On 6/6/20 1:53 AM, Vladimir Sementsov-Ogievskiy wrote: > For patches 05-07: > > Reviewing such patch is a strange thing: Pipfile changes are obvious > enough, just select some version (I can't be sure about correct version > choice, just believe in your commit messages). But what for > Pipfile.

Re: [PATCH 0/7] python: create installable package

2020-06-05 Thread Vladimir Sementsov-Ogievskiy
For patches 05-07: Reviewing such patch is a strange thing: Pipfile changes are obvious enough, just select some version (I can't be sure about correct version choice, just believe in your commit messages). But what for Pipfile.lock? I can state that it's about package set selecting, Pipfile.l

[PATCH 0/7] python: create installable package

2020-06-02 Thread John Snow
Based-on: 20200602214528.12107-1-js...@redhat.com This series factors the python/qemu directory as an installable module. As a developer, you can install this to your virtual environment and then always have access to the classes contained within without needing to wrangle python import path probl