Re: [PATCH 0/7] block: Attempt on fixing 030-reported errors

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > Hanna Reitz (7): > stream: Traverse graph after modification > block: Manipulate children list in .attach/.detach > block: Unite remove_empty_child and child_free > block: Drop detached child from ignore list > block: Pass BdrvChild **

Re: [PATCH 0/7] block: Attempt on fixing 030-reported errors

2021-11-04 Thread Hanna Reitz
On 04.11.21 12:58, Kevin Wolf wrote: Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: (2A) bdrv_replace_child_noperm() should immediately set bs->file or bs->backing to NULL when it sets bs->{file,backing}->bs to NULL. It should also immediately remove any BdrvChild with .bs == NU

Re: [PATCH 0/7] block: Attempt on fixing 030-reported errors

2021-11-04 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > (2A) bdrv_replace_child_noperm() should immediately set bs->file or > bs->backing to NULL when it sets bs->{file,backing}->bs to NULL. > It should also immediately remove any BdrvChild with .bs == NULL > from the parent’s BDS.chil

[PATCH 0/7] block: Attempt on fixing 030-reported errors

2021-11-04 Thread Hanna Reitz
Hi, I’ve tried to investigate what causes the iotest 030 to fail. Here’s what I found: (1) stream_prepare() gets the base node by looking up the node below above_base. It then invokes bdrv_cor_filter_drop(), before we actually use the base node. bdrv_cor_filter_drop() modifies the b