Re: [PATCH 0/7] Enable shared device assignment

2025-01-20 Thread Jason Gunthorpe
On Mon, Jan 20, 2025 at 01:57:36PM +0100, David Hildenbrand wrote: > > I don't want to overload those APIs, I prefer to see a new API that is > > just about splitting areas. Splitting is a special operation that can > > fail depending on driver support. > > So we'd just always perform a split-befo

Re: [PATCH 0/7] Enable shared device assignment

2025-01-15 Thread Jason Gunthorpe
On Wed, Jan 15, 2025 at 02:39:55PM +1100, Alexey Kardashevskiy wrote: > > The thread was talking about the built-in support in iommufd to split > > mappings. > > Just to clarify - I am talking about splitting only "iommufd areas", not > large pages. In generality it is the same thing as you canno

Re: [PATCH 0/7] Enable shared device assignment

2025-01-14 Thread Alexey Kardashevskiy
On 11/1/25 01:14, Jason Gunthorpe wrote: On Fri, Jan 10, 2025 at 02:45:39PM +0100, David Hildenbrand wrote: In your commit I read: "Implement the cut operation to be hitless, changes to the page table during cutting must cause zero disruption to any ongoing DMA. This is the expectation of the

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread Jason Gunthorpe
On Fri, Jan 10, 2025 at 02:45:39PM +0100, David Hildenbrand wrote: > > In your commit I read: > > "Implement the cut operation to be hitless, changes to the page table > during cutting must cause zero disruption to any ongoing DMA. This is the > expectation of the VFIO type 1 uAPI. Hitless requir

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread David Hildenbrand
On 10.01.25 15:14, Jason Gunthorpe wrote: On Fri, Jan 10, 2025 at 02:45:39PM +0100, David Hildenbrand wrote: In your commit I read: "Implement the cut operation to be hitless, changes to the page table during cutting must cause zero disruption to any ongoing DMA. This is the expectation of the

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread David Hildenbrand
On 10.01.25 14:20, Jason Gunthorpe wrote: Thanks for your reply, I knew CCing you would be very helpful :) On Fri, Jan 10, 2025 at 09:26:02AM +0100, David Hildenbrand wrote: One limitation (also discussed in the guest_memfd meeting) is that VFIO expects the DMA mapping for a specific IOVA to b

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread Jason Gunthorpe
On Fri, Jan 10, 2025 at 09:26:02AM +0100, David Hildenbrand wrote: > > > > > > > > > > One limitation (also discussed in the guest_memfd > > > > > > > > > > meeting) is that VFIO expects the DMA mapping for > > > > > > > > > > a specific IOVA to be mapped and unmapped with the > > > > > > > > > > s

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread David Hildenbrand
On 10.01.25 08:06, Chenyi Qiang wrote: On 1/10/2025 9:42 AM, Alexey Kardashevskiy wrote: On 9/1/25 19:49, Chenyi Qiang wrote: On 1/9/2025 4:18 PM, Alexey Kardashevskiy wrote: On 9/1/25 18:52, Chenyi Qiang wrote: On 1/8/2025 7:38 PM, Alexey Kardashevskiy wrote: On 8/1/25 17:28, Ch

Re: [PATCH 0/7] Enable shared device assignment

2025-01-09 Thread Chenyi Qiang
On 1/10/2025 9:42 AM, Alexey Kardashevskiy wrote: > > > On 9/1/25 19:49, Chenyi Qiang wrote: >> >> >> On 1/9/2025 4:18 PM, Alexey Kardashevskiy wrote: >>> >>> >>> On 9/1/25 18:52, Chenyi Qiang wrote: On 1/8/2025 7:38 PM, Alexey Kardashevskiy wrote: > > > On 8/1/25 17

Re: [PATCH 0/7] Enable shared device assignment

2025-01-09 Thread Alexey Kardashevskiy
On 9/1/25 19:49, Chenyi Qiang wrote: On 1/9/2025 4:18 PM, Alexey Kardashevskiy wrote: On 9/1/25 18:52, Chenyi Qiang wrote: On 1/8/2025 7:38 PM, Alexey Kardashevskiy wrote: On 8/1/25 17:28, Chenyi Qiang wrote: Thanks Alexey for your review! On 1/8/2025 12:47 PM, Alexey Kardashevski

Re: [PATCH 0/7] Enable shared device assignment

2025-01-09 Thread Chenyi Qiang
On 1/9/2025 4:18 PM, Alexey Kardashevskiy wrote: > > > On 9/1/25 18:52, Chenyi Qiang wrote: >> >> >> On 1/8/2025 7:38 PM, Alexey Kardashevskiy wrote: >>> >>> >>> On 8/1/25 17:28, Chenyi Qiang wrote: Thanks Alexey for your review! On 1/8/2025 12:47 PM, Alexey Kardashevskiy wrote:

Re: [PATCH 0/7] Enable shared device assignment

2025-01-09 Thread Alexey Kardashevskiy
On 9/1/25 18:52, Chenyi Qiang wrote: On 1/8/2025 7:38 PM, Alexey Kardashevskiy wrote: On 8/1/25 17:28, Chenyi Qiang wrote: Thanks Alexey for your review! On 1/8/2025 12:47 PM, Alexey Kardashevskiy wrote: On 13/12/24 18:08, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_m

Re: [PATCH 0/7] Enable shared device assignment

2025-01-08 Thread Chenyi Qiang
On 1/8/2025 7:38 PM, Alexey Kardashevskiy wrote: > > > On 8/1/25 17:28, Chenyi Qiang wrote: >> Thanks Alexey for your review! >> >> On 1/8/2025 12:47 PM, Alexey Kardashevskiy wrote: >>> On 13/12/24 18:08, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordin

Re: [PATCH 0/7] Enable shared device assignment

2025-01-08 Thread Alexey Kardashevskiy
On 8/1/25 17:28, Chenyi Qiang wrote: Thanks Alexey for your review! On 1/8/2025 12:47 PM, Alexey Kardashevskiy wrote: On 13/12/24 18:08, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") effectively disables device assignment when using guest

Re: [PATCH 0/7] Enable shared device assignment

2025-01-07 Thread Chenyi Qiang
Thanks Alexey for your review! On 1/8/2025 12:47 PM, Alexey Kardashevskiy wrote: > On 13/12/24 18:08, Chenyi Qiang wrote: >> Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated >> discard") effectively disables device assignment when using guest_memfd. >> This poses a significant

Re: [PATCH 0/7] Enable shared device assignment

2025-01-07 Thread Alexey Kardashevskiy
On 13/12/24 18:08, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") effectively disables device assignment when using guest_memfd. This poses a significant challenge as guest_memfd is essential for confidential guests, thereby blocking device assi

[PATCH 0/7] Enable shared device assignment

2024-12-12 Thread Chenyi Qiang
Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") effectively disables device assignment when using guest_memfd. This poses a significant challenge as guest_memfd is essential for confidential guests, thereby blocking device assignment to these VMs. The initial rational