Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-16 Thread Pierrick Bouvier
I don't have strong opinion in the end, I'm just looking for building contrib plugins like the rest of the codebase, to reduce maintenance burden. Initially, when this idea was implemented, it was suggested by Alex to remove the Makefile [1]. Now it seems to be suggested to keep it as an exampl

Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-15 Thread Philippe Mathieu-Daudé
On 15/8/24 20:04, Pierrick Bouvier wrote: On 8/14/24 23:00, Paolo Bonzini wrote: On Thu, Aug 15, 2024 at 1:37 AM Pierrick Bouvier wrote: Contrib plugins have been built out of tree so far, thanks to a Makefile. However, it is quite inconvenient for maintenance, as we may break them, especiall

Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-15 Thread Peter Maydell
On Thu, 15 Aug 2024 at 19:38, Paolo Bonzini wrote: > > On Thu, Aug 15, 2024 at 8:04 PM Pierrick Bouvier > wrote: > > > One argument from moving contrib/plugins to meson is that the Windows > > > case depends on libqemu_plugin_api.a which is built with meson(*); > > > that said, libqemu_plugin_api

Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-15 Thread Paolo Bonzini
On Thu, Aug 15, 2024 at 8:04 PM Pierrick Bouvier wrote: > > One argument from moving contrib/plugins to meson is that the Windows > > case depends on libqemu_plugin_api.a which is built with meson(*); > > that said, libqemu_plugin_api.a should be installed - which would > > justify it being used f

Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-15 Thread Pierrick Bouvier
On 8/14/24 23:00, Paolo Bonzini wrote: On Thu, Aug 15, 2024 at 1:37 AM Pierrick Bouvier wrote: Contrib plugins have been built out of tree so far, thanks to a Makefile. However, it is quite inconvenient for maintenance, as we may break them, especially for specific architectures. First patches

Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-15 Thread Pierrick Bouvier
On 8/15/24 04:42, Alex Bennée wrote: Paolo Bonzini writes: On Thu, Aug 15, 2024 at 1:37 AM Pierrick Bouvier wrote: Contrib plugins have been built out of tree so far, thanks to a Makefile. However, it is quite inconvenient for maintenance, as we may break them, especially for specific archit

Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-15 Thread Alex Bennée
Paolo Bonzini writes: > On Thu, Aug 15, 2024 at 1:37 AM Pierrick Bouvier > wrote: >> Contrib plugins have been built out of tree so far, thanks to a Makefile. >> However, it is quite inconvenient for maintenance, as we may break them, >> especially for specific architectures. >> >> First patches

Re: [PATCH 0/6] build contrib/plugins using meson

2024-08-14 Thread Paolo Bonzini
On Thu, Aug 15, 2024 at 1:37 AM Pierrick Bouvier wrote: > Contrib plugins have been built out of tree so far, thanks to a Makefile. > However, it is quite inconvenient for maintenance, as we may break them, > especially for specific architectures. > > First patches are fixing warnings for existing

[PATCH 0/6] build contrib/plugins using meson

2024-08-14 Thread Pierrick Bouvier
Contrib plugins have been built out of tree so far, thanks to a Makefile. However, it is quite inconvenient for maintenance, as we may break them, especially for specific architectures. First patches are fixing warnings for existing plugins, then we add meson support, and finally, we remove Makefi