Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704)

2021-11-10 Thread Laurent Vivier
Le 07/11/2021 à 13:48, Richard Henderson a écrit : There are a number of alignement issues flagged up by clang, this attempts to fix only one of them: getdents. r~ Richard Henderson (4): linux-user: Split out do_getdents, do_getdents64 linux-user: Always use flexible arrays for dirent d_n

Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704)

2021-11-10 Thread Richard Henderson
On 11/9/21 5:46 PM, Warner Losh wrote: On Nov 7, 2021, at 5:48 AM, Richard Henderson wrote: There are a number of alignement issues flagged up by clang, this attempts to fix only one of them: getdents. Does it make sense to have size asserts for these types? That would catch the alignmen

Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704)

2021-11-09 Thread Warner Losh
> On Nov 7, 2021, at 5:48 AM, Richard Henderson > wrote: > > There are a number of alignement issues flagged up by clang, > this attempts to fix only one of them: getdents. Does it make sense to have size asserts for these types? That would catch the alignment issues and are cheap to mainta

[PATCH 0/4] linux-user: Fix getdents alignment issues (#704)

2021-11-07 Thread Richard Henderson
There are a number of alignement issues flagged up by clang, this attempts to fix only one of them: getdents. r~ Richard Henderson (4): linux-user: Split out do_getdents, do_getdents64 linux-user: Always use flexible arrays for dirent d_name linux-user: Fix member types of target_dirent64