Re: [PATCH 0/4] Refactor x86_load_linux and pass RNG seed via setup_data entry

2022-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2022 at 05:11:31PM +0200, Jason A. Donenfeld wrote: > Hi Michael, > > On Thu, Jul 21, 2022 at 10:52:32AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 21, 2022 at 02:29:33PM +0200, Paolo Bonzini wrote: > > > As mentioned in the reviews of Jason's patches, the fw_cfg data, or at

Re: [PATCH 0/4] Refactor x86_load_linux and pass RNG seed via setup_data entry

2022-07-21 Thread Jason A. Donenfeld
Hi Michael, On Thu, Jul 21, 2022 at 10:52:32AM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 21, 2022 at 02:29:33PM +0200, Paolo Bonzini wrote: > > As mentioned in the reviews of Jason's patches, the fw_cfg data, or at > > least its structure including the size, is part of the guest ABI and > > m

Re: [PATCH 0/4] Refactor x86_load_linux and pass RNG seed via setup_data entry

2022-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2022 at 02:29:33PM +0200, Paolo Bonzini wrote: > As mentioned in the reviews of Jason's patches, the fw_cfg data, or at > least its structure including the size, is part of the guest ABI and > must match across two sides of migration. > > It would be possible to handle this with so

[PATCH 0/4] Refactor x86_load_linux and pass RNG seed via setup_data entry

2022-07-21 Thread Paolo Bonzini
As mentioned in the reviews of Jason's patches, the fw_cfg data, or at least its structure including the size, is part of the guest ABI and must match across two sides of migration. It would be possible to handle this with some duplicated code between the rng seed and DTB handling, but the conditi