Re: [PATCH 0/4] QOM: Singleton interface

2024-12-11 Thread Peter Xu
On Wed, Dec 11, 2024 at 09:19:32AM +0100, Markus Armbruster wrote: > Looked at this thread again to refresh my memory on the proposed > singleton interface, and found I have something to add. > > Peter Xu writes: > > > On Tue, Oct 29, 2024 at 04:04:50PM +, Daniel P. Berrangé wrote: > >> I te

Re: [PATCH 0/4] QOM: Singleton interface

2024-12-11 Thread Markus Armbruster
Looked at this thread again to refresh my memory on the proposed singleton interface, and found I have something to add. Peter Xu writes: > On Tue, Oct 29, 2024 at 04:04:50PM +, Daniel P. Berrangé wrote: >> I tend to feel that having MigrationState exist for the whole lifetime >> of QEMU is

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-29 Thread Daniel P . Berrangé
On Tue, Oct 29, 2024 at 01:05:04PM -0400, Peter Xu wrote: > But I'm not sure whether that's a concern at all for Libvirt, if what > Libvirt currently does is having separate "migrate-set-*" commands prior to > the "migrate". I may have overlooked the real issue behind on how that > could complicat

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-29 Thread Peter Xu
On Tue, Oct 29, 2024 at 04:04:50PM +, Daniel P. Berrangé wrote: > On Tue, Oct 29, 2024 at 10:45:25AM -0400, Peter Xu wrote: > > On Tue, Oct 29, 2024 at 10:42:58AM +, Daniel P. Berrangé wrote: > > > On Fri, Oct 25, 2024 at 11:01:56AM -0400, Peter Xu wrote: > > > > On Fri, Oct 25, 2024 at 09:

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-29 Thread Daniel P . Berrangé
On Tue, Oct 29, 2024 at 10:45:25AM -0400, Peter Xu wrote: > On Tue, Oct 29, 2024 at 10:42:58AM +, Daniel P. Berrangé wrote: > > On Fri, Oct 25, 2024 at 11:01:56AM -0400, Peter Xu wrote: > > > On Fri, Oct 25, 2024 at 09:38:31AM +0200, Markus Armbruster wrote: > > > > Peter Xu writes: > > > > >

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-29 Thread Peter Xu
On Tue, Oct 29, 2024 at 10:42:58AM +, Daniel P. Berrangé wrote: > On Fri, Oct 25, 2024 at 11:01:56AM -0400, Peter Xu wrote: > > On Fri, Oct 25, 2024 at 09:38:31AM +0200, Markus Armbruster wrote: > > > Peter Xu writes: > > > > > > > This patchset introduces the singleton interface for QOM. > >

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-29 Thread Daniel P . Berrangé
On Fri, Oct 25, 2024 at 11:01:56AM -0400, Peter Xu wrote: > On Fri, Oct 25, 2024 at 09:38:31AM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > This patchset introduces the singleton interface for QOM. > > > > > > The singleton interface is as simple as "this class can only create o

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-25 Thread Peter Xu
On Fri, Oct 25, 2024 at 09:38:31AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > This patchset introduces the singleton interface for QOM. > > > > The singleton interface is as simple as "this class can only create one > > instance". > > > > We used to have similar demand when working

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-25 Thread Markus Armbruster
Peter Xu writes: > This patchset introduces the singleton interface for QOM. > > The singleton interface is as simple as "this class can only create one > instance". > > We used to have similar demand when working on all kinds of vIOMMUs, > because in most cases that I am aware of, vIOMMU must be

[PATCH 0/4] QOM: Singleton interface

2024-10-24 Thread Peter Xu
This patchset introduces the singleton interface for QOM. The singleton interface is as simple as "this class can only create one instance". We used to have similar demand when working on all kinds of vIOMMUs, because in most cases that I am aware of, vIOMMU must be a singleton as it's closely bo