Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-27 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 27 Oct 2022 at 18:17, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > On Thu, 27 Oct 2022 at 15:40, Markus Armbruster wrote: >> >> I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why >> >> not .h and call it a day? No need to conf

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-27 Thread Peter Maydell
On Thu, 27 Oct 2022 at 18:17, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Thu, 27 Oct 2022 at 15:40, Markus Armbruster wrote: > >> I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why > >> not .h and call it a day? No need to configure each and every editor to >

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-27 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 27 Oct 2022 at 15:40, Markus Armbruster wrote: >> I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why >> not .h and call it a day? No need to configure each and every editor to >> tread these as C code. > > It says "this isn't actually a header

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-27 Thread Thomas Huth
On 27/10/2022 16.12, Philippe Mathieu-Daudé wrote: On 27/10/22 08:46, Thomas Huth wrote: On 26/10/2022 01.50, Philippe Mathieu-Daudé wrote: We use the .h.inc extension to include C headers. To be consistent with the rest of the codebase, rename the C headers using the .def extension. IDE/tools

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-27 Thread Peter Maydell
On Thu, 27 Oct 2022 at 15:40, Markus Armbruster wrote: > I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why > not .h and call it a day? No need to configure each and every editor to > tread these as C code. It says "this isn't actually a header in the usual sense". That's usef

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-27 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > We use the .h.inc extension to include C headers. To be consistent > with the rest of the codebase, rename the C headers using the .def > extension. > > IDE/tools using our .editorconfig / .gitattributes will leverage > this consistency. > > Philippe Mathieu-Daudé

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-27 Thread Philippe Mathieu-Daudé
On 27/10/22 08:46, Thomas Huth wrote: On 26/10/2022 01.50, Philippe Mathieu-Daudé wrote: We use the .h.inc extension to include C headers. To be consistent with the rest of the codebase, rename the C headers using the .def extension. IDE/tools using our .editorconfig / .gitattributes will lever

Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-26 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > We use the .h.inc extension to include C headers. To be consistent > with the rest of the codebase, rename the C headers using the .def > extension. > > IDE/tools using our .editorconfig / .gitattributes will leverage > this consistency. Reviewed-by: Alex Benné

[PATCH 0/3] target: Rename headers using .def extension to .h.inc

2022-10-25 Thread Philippe Mathieu-Daudé
We use the .h.inc extension to include C headers. To be consistent with the rest of the codebase, rename the C headers using the .def extension. IDE/tools using our .editorconfig / .gitattributes will leverage this consistency. Philippe Mathieu-Daudé (3): target/m68k: Rename qregs.def -> qregs.