Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-16 Thread Paolo Bonzini
On Mon, Oct 16, 2023 at 10:05 PM Phil Dennis-Jordan wrote: > > I think fd and the HVF type should be placed in an anonymous union. > > Taking a look at the code and thinking through the implications, I'm > not actually sure what the intention of the union is Nevermind, I got confused that AccelCP

Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-16 Thread Phil Dennis-Jordan
On Mon, 16 Oct 2023 at 18:49, Paolo Bonzini wrote: > > switching to hv_vcpu_run_until() WITHOUT hv_vcpu_interrupt() > > causes some very obvious problems where the vCPU simply > > doesn't exit at all for long periods.) > > Yes, that makes sense. It looks like hv_vcpu_run_until() has an > equivalen

Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-16 Thread Paolo Bonzini
On Mon, Oct 16, 2023 at 6:45 PM Phil Dennis-Jordan wrote: > > Hi Paolo, > > > On Mon, 16 Oct 2023 at 16:39, Paolo Bonzini wrote: > > > > On 9/22/23 16:09, Phil Dennis-Jordan wrote: > > > Patch 1 enables the INVTSC CPUID bit when running with hvf. This can > > > enable some optimisations in the gu

Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-16 Thread Phil Dennis-Jordan
Hi Paolo, On Mon, 16 Oct 2023 at 16:39, Paolo Bonzini wrote: > > On 9/22/23 16:09, Phil Dennis-Jordan wrote: > > Patch 1 enables the INVTSC CPUID bit when running with hvf. This can > > enable some optimisations in the guest OS, and I've not found any reason > > it shouldn't be allowed for hvf b

Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-16 Thread Paolo Bonzini
On 9/22/23 16:09, Phil Dennis-Jordan wrote: Patch 1 enables the INVTSC CPUID bit when running with hvf. This can enable some optimisations in the guest OS, and I've not found any reason it shouldn't be allowed for hvf based hosts. It can be enabled, but it should include a migration blocker.

Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-05 Thread Phil Dennis-Jordan
Ping - let me know if there's anything particularly controversial, unclear, etc. about these patches or if I can do anything to make reviewing easier. Thanks! On Fri, 22 Sept 2023 at 16:09, Phil Dennis-Jordan wrote: > > This is a series of semi-related patches for the x86 macOS > Hypervisor.fr

[PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-09-22 Thread Phil Dennis-Jordan
This is a series of semi-related patches for the x86 macOS Hypervisor.framework (hvf) accelerator backend. The intention is to make VMs run slightly more efficiently on macOS host machines. They have been subject to some months of CI workloads with macOS guest VMs without issues and they seem to gi