Re: [PATCH 0/2] docs: Avoid duplicate labels with a sphinx extn

2025-06-09 Thread Paolo Bonzini
On 6/9/25 18:18, Peter Maydell wrote: Ping^2 on this one? No objections if it's the easiest way to solve the issue. Alternatively, is there a Sphinx way to write something in the spirit of #ifdef DEFINE_THE_LABEL .. _label #endif This way, you could have the nbd label enabled when including

Re: [PATCH 0/2] docs: Avoid duplicate labels with a sphinx extn

2025-06-09 Thread Peter Maydell
On Mon, 9 Jun 2025 at 17:38, Paolo Bonzini wrote: > > On 6/9/25 18:18, Peter Maydell wrote: > > Ping^2 on this one? > > No objections if it's the easiest way to solve the issue. > > Alternatively, is there a Sphinx way to write something in the spirit of > > #ifdef DEFINE_THE_LABEL > .. _label > #

Re: [PATCH 0/2] docs: Avoid duplicate labels with a sphinx extn

2025-06-09 Thread Peter Maydell
Ping^2 on this one? -- PMM On Mon, 19 May 2025 at 15:32, Peter Maydell wrote: > > Ping? Any opinions on this? > > In the interim we've applied commit 82707dd4f0 to drop > the specific duplicate-label that is causing problems > right now, so patch 2 here will need the obvious trivial > update. Bu

Re: [PATCH 0/2] docs: Avoid duplicate labels with a sphinx extn

2025-05-19 Thread Peter Maydell
Ping? Any opinions on this? In the interim we've applied commit 82707dd4f0 to drop the specific duplicate-label that is causing problems right now, so patch 2 here will need the obvious trivial update. But I do think this is a better approach than forever avoiding defining labels in .rst.inc files

[PATCH 0/2] docs: Avoid duplicate labels with a sphinx extn

2025-04-29 Thread Peter Maydell
Sphinx requires that labels within documents are unique across the whole manual. This is because the "create a hyperlink" directive specifies only the name of the label, not a filename+label. Some Sphinx versions will warn about duplicate labels, but even if there is no warning there is still an