Re: [PATCH v2 4/7] configure: don't enable cross compilers unless in target_list

2022-10-14 Thread Paolo Bonzini
On 10/14/22 10:13, Alex Bennée wrote: @@ -1866,6 +1866,15 @@ probe_target_compiler() { container_cross_ranlib= container_cross_strip= + # We shall skip configuring the target compiler if the user didn't + # bother enabling an appropriate guest. This avoids building + # extraneous f

Re: [PATCH v2 4/7] configure: don't enable cross compilers unless in target_list

2022-10-14 Thread Alex Bennée
Paolo Bonzini writes: > On 10/13/22 21:48, Alex Bennée wrote: >>> + case " $target_list " in >>> +" $1 ") ;; >>> +*) return 1 ;; >>> + esac >>> + >> this of course prevents building of roms by actually disabling all >> target compilers... > > Yeah, two asterisks are missing. I'll sen

Re: [PATCH v2 4/7] configure: don't enable cross compilers unless in target_list

2022-10-13 Thread Paolo Bonzini
On 10/13/22 21:48, Alex Bennée wrote: + case " $target_list " in +" $1 ") ;; +*) return 1 ;; + esac + this of course prevents building of roms by actually disabling all target compilers... Yeah, two asterisks are missing. I'll send out a proper patch. Paolo

Re: [PATCH v2 4/7] configure: don't enable cross compilers unless in target_list

2022-10-13 Thread Alex Bennée
Alex Bennée writes: > This avoids the unfortunate effect of always builds the pc-bios blobs > for targets the user isn't interested in. > > Suggested-by: Paolo Bonzini > Signed-off-by: Alex Bennée > --- > configure | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/configure b/con

[PATCH v2 4/7] configure: don't enable cross compilers unless in target_list

2022-10-13 Thread Alex Bennée
This avoids the unfortunate effect of always builds the pc-bios blobs for targets the user isn't interested in. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 45ee6f4eb3..246651f25d 100755