Re: [PATCH-for-8.2 v2] backends/cryptodev: Do not ignore throttle/backends Errors

2024-01-18 Thread Michael Tokarev
20.11.2023 18:04, Philippe Mathieu-Daudé: Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init() can set their Error** argument. Do not ignore them, return early on failure. Use the ERRP_GUARD() macro as suggested in commit ae7c80a7bd ("error: New macro ERRP_GUARD()"). Cc: qemu-

Re: [PATCH-for-8.2 v2] backends/cryptodev: Do not ignore throttle/backends Errors

2023-11-20 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init() > can set their Error** argument. Do not ignore them, return early on > failure. Let's mention why we need to: "Without that, running into another failure trips error_setv()'s assertion." >

RE: [PATCH-for-8.2 v2] backends/cryptodev: Do not ignore throttle/backends Errors

2023-11-20 Thread Gonglei (Arei)
; qemu-sta...@nongnu.org > Subject: [PATCH-for-8.2 v2] backends/cryptodev: Do not ignore > throttle/backends Errors > > Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init() can > set their Error** argument. Do not ignore them, return early on failure. Use > the

Re: [PATCH-for-8.2 v2] backends/cryptodev: Do not ignore throttle/backends Errors

2023-11-20 Thread zhenwei pi
Looks good to me. Thanks! Reviewed-by: zhenwei pi On 11/20/23 23:04, Philippe Mathieu-Daudé wrote: Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init() can set their Error** argument. Do not ignore them, return early on failure. Use the ERRP_GUARD() macro as suggested in com

[PATCH-for-8.2 v2] backends/cryptodev: Do not ignore throttle/backends Errors

2023-11-20 Thread Philippe Mathieu-Daudé
Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init() can set their Error** argument. Do not ignore them, return early on failure. Use the ERRP_GUARD() macro as suggested in commit ae7c80a7bd ("error: New macro ERRP_GUARD()"). Cc: qemu-sta...@nongnu.org Fixes: e7a775fd9f ("crypto