Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path

2023-11-16 Thread Manos Pitsidianakis
On Thu, 16 Nov 2023 10:54, Philippe Mathieu-Daudé wrote: On 16/11/23 09:48, Manos Pitsidianakis wrote: On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé wrote: On 16/11/23 08:33, Manos Pitsidianakis wrote: On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé wrote: --- Notes: Requires p

Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path

2023-11-16 Thread Philippe Mathieu-Daudé
On 16/11/23 09:48, Manos Pitsidianakis wrote: On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé wrote: On 16/11/23 08:33, Manos Pitsidianakis wrote: On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé wrote: --- Notes: Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.

Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path

2023-11-16 Thread Manos Pitsidianakis
On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé wrote: On 16/11/23 08:33, Manos Pitsidianakis wrote: On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé wrote: --- Notes: Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.org> This is the 'Based-on: ' tag I guess.

Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path

2023-11-16 Thread Philippe Mathieu-Daudé
On 16/11/23 08:33, Manos Pitsidianakis wrote: On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé wrote: --- Notes: Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.org> This is the 'Based-on: ' tag I guess. There is  prerequisite-patch-id: 484ec9f7f6109c10d4be0484

Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path

2023-11-15 Thread Manos Pitsidianakis
On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé wrote: --- Notes: Requires patch <20231109162034.2108018-1-manos.pitsidiana...@linaro.org> This is the 'Based-on: ' tag I guess. There is prerequisite-patch-id: 484ec9f7f6109c10d4be0484fe8e3c2550c415f4 At the end of the patch, added

Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path

2023-11-15 Thread Philippe Mathieu-Daudé
Hi Manos, On 16/11/23 08:20, Manos Pitsidianakis wrote: QEMU crashes on exit when a virtio-sound device has failed to realise. Its vmstate field was not cleaned up properly with qemu_del_vm_change_state_handler(). This patch changes the realize() order as 1. Validate the given configuration va

[PATCH-for-8.2] virtio-sound: add realize() error cleanup path

2023-11-15 Thread Manos Pitsidianakis
QEMU crashes on exit when a virtio-sound device has failed to realise. Its vmstate field was not cleaned up properly with qemu_del_vm_change_state_handler(). This patch changes the realize() order as 1. Validate the given configuration values (no resources allocated by us either on success or