Re: [PATCH-for-8.0 2/3] hw/intc: Move omap_lcdc.c out of target-specific source set

2022-12-10 Thread Thomas Huth
I suggest to change the subject since you move more than just the omap controller. On 09/12/2022 18.00, Philippe Mathieu-Daudé wrote: The Goldfish interrupt controller is not target specific. While the Exynos interrupt combiner is only used by the ARM targets, we can build this device once

Re: [PATCH-for-8.0 2/3] hw/intc: Move omap_lcdc.c out of target-specific source set

2022-12-09 Thread Philippe Mathieu-Daudé
On 9/12/22 18:21, Thomas Huth wrote: On 09/12/2022 18.00, Philippe Mathieu-Daudé wrote: The Goldfish interrupt controller is not target specific. It's also only used by m68k which is only built once, so this does help reducing the compile time ... but I agree, it will be more helpful in the

Re: [PATCH-for-8.0 2/3] hw/intc: Move omap_lcdc.c out of target-specific source set

2022-12-09 Thread Thomas Huth
On 09/12/2022 18.00, Philippe Mathieu-Daudé wrote: The Goldfish interrupt controller is not target specific. It's also only used by m68k which is only built once, so this does help reducing the compile time ... but I agree, it will be more helpful in the future the more code we move to softmm

[PATCH-for-8.0 2/3] hw/intc: Move omap_lcdc.c out of target-specific source set

2022-12-09 Thread Philippe Mathieu-Daudé
The Goldfish interrupt controller is not target specific. While the Exynos interrupt combiner is only used by the ARM targets, we can build this device once for all. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/meson.build | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --