Re: [PATCH-for-6.2 v2 3/5] target/mips: Convert Vr54xx MACC* opcodes to decodetree

2021-08-07 Thread Philippe Mathieu-Daudé
On 8/6/21 11:42 PM, Richard Henderson wrote: > On 8/6/21 11:05 AM, Philippe Mathieu-Daudé wrote: >> +/* >> + * Helpers for implementing sets of trans_* functions. >> + * Defer the implementation of NAME to FUNC, with optional extra >> arguments. >> + */ >> +#define TRANS(NAME, FUNC, ...) \ >> +   

Re: [PATCH-for-6.2 v2 3/5] target/mips: Convert Vr54xx MACC* opcodes to decodetree

2021-08-06 Thread Richard Henderson
On 8/6/21 11:05 AM, Philippe Mathieu-Daudé wrote: +/* + * Helpers for implementing sets of trans_* functions. + * Defer the implementation of NAME to FUNC, with optional extra arguments. + */ +#define TRANS(NAME, FUNC, ...) \ +static bool trans_##NAME(DisasContext *ctx, arg_##NAME *a) \ +

[PATCH-for-6.2 v2 3/5] target/mips: Convert Vr54xx MACC* opcodes to decodetree

2021-08-06 Thread Philippe Mathieu-Daudé
Convert the following Integer Multiply-Accumulate opcodes: * MACC Multiply, accumulate, and move LO * MACCHI Multiply, accumulate, and move HI * MACCHIU Unsigned multiply, accumulate, and move HI * MACCUUnsigned multiply, accumulate, and move LO Since all opcodes ar