Re: [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event()

2020-08-17 Thread Paolo Bonzini
On 05/08/20 13:49, Thomas Huth wrote: >> ... as this is the current behavior. > But could we maybe end up in a scenario, where the stub from > stubs/cpu-get-icount.c is used, which then calls the real implementation > of qemu_notify_event() in main-loop.c ? Yes, definitely. It would happen in too

Re: [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event()

2020-08-05 Thread Thomas Huth
On 05/08/2020 11.59, Philippe Mathieu-Daudé wrote: > On 8/5/20 11:42 AM, Philippe Mathieu-Daudé wrote: >> On 8/5/20 10:55 AM, Philippe Mathieu-Daudé wrote: >>> We don't need the qemu_notify_event() stub anymore. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> stubs/cpu-get-icount.c | 2

Re: [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event()

2020-08-05 Thread Philippe Mathieu-Daudé
On 8/5/20 11:42 AM, Philippe Mathieu-Daudé wrote: > On 8/5/20 10:55 AM, Philippe Mathieu-Daudé wrote: >> We don't need the qemu_notify_event() stub anymore. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> stubs/cpu-get-icount.c | 2 +- >> stubs/notify-event.c | 6 -- >> stubs/Makefile

Re: [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event()

2020-08-05 Thread Philippe Mathieu-Daudé
On 8/5/20 10:55 AM, Philippe Mathieu-Daudé wrote: > We don't need the qemu_notify_event() stub anymore. > > Signed-off-by: Philippe Mathieu-Daudé > --- > stubs/cpu-get-icount.c | 2 +- > stubs/notify-event.c | 6 -- > stubs/Makefile.objs| 1 - > 3 files changed, 1 insertion(+), 8 delet

[PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event()

2020-08-05 Thread Philippe Mathieu-Daudé
We don't need the qemu_notify_event() stub anymore. Signed-off-by: Philippe Mathieu-Daudé --- stubs/cpu-get-icount.c | 2 +- stubs/notify-event.c | 6 -- stubs/Makefile.objs| 1 - 3 files changed, 1 insertion(+), 8 deletions(-) delete mode 100644 stubs/notify-event.c diff --git a/stu