Re: [PATCH-for-5.1] hw/isa/isa-superio: Fix IDE controller realization

2020-07-21 Thread Philippe Mathieu-Daudé
On 7/21/20 11:57 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 7/21/20 10:15 AM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> When realizing a Super I/O with IDE controller [*], we get: qom/object.c:1684: object_property_try_add_child:

Re: [PATCH-for-5.1] hw/isa/isa-superio: Fix IDE controller realization

2020-07-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/21/20 10:15 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> When realizing a Super I/O with IDE controller [*], we get: >>> >>> qom/object.c:1684: object_property_try_add_child: Assertion >>> `!child->parent' failed. >>> Aborted (

Re: [PATCH-for-5.1] hw/isa/isa-superio: Fix IDE controller realization

2020-07-21 Thread Philippe Mathieu-Daudé
On 7/21/20 10:15 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> When realizing a Super I/O with IDE controller [*], we get: >> >> qom/object.c:1684: object_property_try_add_child: Assertion >> `!child->parent' failed. >> Aborted (core dumped) >> >> This is because the dev

Re: [PATCH-for-5.1] hw/isa/isa-superio: Fix IDE controller realization

2020-07-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > When realizing a Super I/O with IDE controller [*], we get: > > qom/object.c:1684: object_property_try_add_child: Assertion > `!child->parent' failed. > Aborted (core dumped) > > This is because the device is already realized when we try to > add the QOM prop

Re: [PATCH-for-5.1] hw/isa/isa-superio: Fix IDE controller realization

2020-07-20 Thread Richard Henderson
On 7/20/20 10:23 AM, Philippe Mathieu-Daudé wrote: > When realizing a Super I/O with IDE controller [*], we get: > > qom/object.c:1684: object_property_try_add_child: Assertion > `!child->parent' failed. > Aborted (core dumped) > > This is because the device is already realized when we try t

[PATCH-for-5.1] hw/isa/isa-superio: Fix IDE controller realization

2020-07-20 Thread Philippe Mathieu-Daudé
When realizing a Super I/O with IDE controller [*], we get: qom/object.c:1684: object_property_try_add_child: Assertion `!child->parent' failed. Aborted (core dumped) This is because the device is already realized when we try to add the QOM property to the parent. Fix by realizing *after* ad