Re: [PATCH-for-5.1] gdbstub: Rename GByteArray variable 'mem_buf' as 'array'

2020-04-14 Thread David Gibson
On Tue, Apr 14, 2020 at 01:28:48PM +0200, Philippe Mathieu-Daudé wrote: > GByteArray type has should not be treated as a u8[] buffer. > The GLib Byte Arrays API should be used instead. > Rename the 'mem_buf' variable as 'array' to make it more > obvious in the code. > > Signed-off-by: Philippe Mat

Re: [PATCH-for-5.1] gdbstub: Rename GByteArray variable 'mem_buf' as 'array'

2020-04-14 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 4/14/20 3:35 PM, Aleksandar Markovic wrote: >> 1:28 PM Uto, 14.04.2020. Philippe Mathieu-Daudé > > је написао/ла: >> > >> > GByteArray type has should not be treated as a u8[] buffer. >> > The GLib Byte Arrays API should be used i

Re: [PATCH-for-5.1] gdbstub: Rename GByteArray variable 'mem_buf' as 'array'

2020-04-14 Thread Philippe Mathieu-Daudé
On 4/14/20 3:35 PM, Aleksandar Markovic wrote: 1:28 PM Uto, 14.04.2020. Philippe Mathieu-Daudé > је написао/ла: > > GByteArray type has should not be treated as a u8[] buffer. > The GLib Byte Arrays API should be used instead. > Rename the 'mem_buf' variable as 'arra

Re: [PATCH-for-5.1] gdbstub: Rename GByteArray variable 'mem_buf' as 'array'

2020-04-14 Thread Philippe Mathieu-Daudé
On 4/14/20 1:28 PM, Philippe Mathieu-Daudé wrote: GByteArray type has should not be treated as a u8[] buffer. The GLib Byte Arrays API should be used instead. Rename the 'mem_buf' variable as 'array' to make it more obvious in the code. I forgot to mention this variable was used as u8[] buffer

[PATCH-for-5.1] gdbstub: Rename GByteArray variable 'mem_buf' as 'array'

2020-04-14 Thread Philippe Mathieu-Daudé
GByteArray type has should not be treated as a u8[] buffer. The GLib Byte Arrays API should be used instead. Rename the 'mem_buf' variable as 'array' to make it more obvious in the code. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20200414111846.27495-1-phi...@redhat.com> Signed-off-by: