Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-06-01 Thread Jon Doron
On 01/06/2020, Alex Bennée wrote: Jon Doron writes: On 31/05/2020, Peter Maydell wrote: On Sun, 31 May 2020 at 17:42, Jon Doron wrote: On 31/05/2020, Philippe Mathieu-Daudé wrote: >On 3/30/20 6:41 PM, Peter Maydell wrote: >> PS: do we have any documentation of this new command ? >> ab4752

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-06-01 Thread Alex Bennée
Jon Doron writes: > On 31/05/2020, Peter Maydell wrote: >>On Sun, 31 May 2020 at 17:42, Jon Doron wrote: >>> >>> On 31/05/2020, Philippe Mathieu-Daudé wrote: >>> >On 3/30/20 6:41 PM, Peter Maydell wrote: >>> >> PS: do we have any documentation of this new command ? >>> >> ab4752ec8d9 has the i

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-06-01 Thread Jon Doron
On 31/05/2020, Peter Maydell wrote: On Sun, 31 May 2020 at 17:42, Jon Doron wrote: On 31/05/2020, Philippe Mathieu-Daudé wrote: >On 3/30/20 6:41 PM, Peter Maydell wrote: >> PS: do we have any documentation of this new command ? >> ab4752ec8d9 has the implementation but no documentation... > >J

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-05-31 Thread Peter Maydell
On Sun, 31 May 2020 at 17:42, Jon Doron wrote: > > On 31/05/2020, Philippe Mathieu-Daudé wrote: > >On 3/30/20 6:41 PM, Peter Maydell wrote: > >> PS: do we have any documentation of this new command ? > >> ab4752ec8d9 has the implementation but no documentation... > > > >Jon, do you have documentat

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-05-31 Thread Jon Doron
On 31/05/2020, Philippe Mathieu-Daudé wrote: On 3/30/20 6:41 PM, Peter Maydell wrote: On Mon, 30 Mar 2020 at 17:21, Philippe Mathieu-Daudé wrote: On 3/30/20 6:08 PM, Peter Maydell wrote: On Mon, 30 Mar 2020 at 16:30, Philippe Mathieu-Daudé wrote: Since commit 3f940dc98, we added support fo

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-05-31 Thread Philippe Mathieu-Daudé
On 3/30/20 6:41 PM, Peter Maydell wrote: > On Mon, 30 Mar 2020 at 17:21, Philippe Mathieu-Daudé > wrote: >> On 3/30/20 6:08 PM, Peter Maydell wrote: >>> On Mon, 30 Mar 2020 at 16:30, Philippe Mathieu-Daudé >>> wrote: Since commit 3f940dc98, we added support for vAttach packet to

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-03-30 Thread Peter Maydell
On Mon, 30 Mar 2020 at 17:21, Philippe Mathieu-Daudé wrote: > > On 3/30/20 6:08 PM, Peter Maydell wrote: > > On Mon, 30 Mar 2020 at 16:30, Philippe Mathieu-Daudé > > wrote: > >> > >> Since commit 3f940dc98, we added support for vAttach packet > >> to select a particular thread/cpu/core. However

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-03-30 Thread Philippe Mathieu-Daudé
On 3/30/20 6:08 PM, Peter Maydell wrote: On Mon, 30 Mar 2020 at 16:30, Philippe Mathieu-Daudé wrote: Since commit 3f940dc98, we added support for vAttach packet to select a particular thread/cpu/core. However when using the GDB physical memory mode, it is not clear which CPU address space is u

Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-03-30 Thread Peter Maydell
On Mon, 30 Mar 2020 at 16:30, Philippe Mathieu-Daudé wrote: > > Since commit 3f940dc98, we added support for vAttach packet > to select a particular thread/cpu/core. However when using > the GDB physical memory mode, it is not clear which CPU > address space is used. > Since the CPU address space

[PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

2020-03-30 Thread Philippe Mathieu-Daudé
Since commit 3f940dc98, we added support for vAttach packet to select a particular thread/cpu/core. However when using the GDB physical memory mode, it is not clear which CPU address space is used. Since the CPU address space is stored in CPUState::as, use address_space_rw() instead of cpu_physical