Re: [PATCH] x86: Check for machine state object class before typecasting it

2020-01-07 Thread Paolo Bonzini
On 30/12/19 14:17, Michal Prívozník wrote: > On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: >> On 12/30/19 10:35 AM, Michal Prívozník wrote: >>> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:00 AM, Michal Privoznik wrote: > In v4.2.0-246-ged9e923c3c the SMM property

Re: [PATCH] x86: Check for machine state object class before typecasting it

2019-12-30 Thread Philippe Mathieu-Daudé
On 12/30/19 2:17 PM, Michal Prívozník wrote: On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 10:35 AM, Michal Prívozník wrote: On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved f

Re: [PATCH] x86: Check for machine state object class before typecasting it

2019-12-30 Thread Michal Prívozník
On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 10:35 AM, Michal Prívozník wrote: >> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: >>> On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved from PC >>> >>> Typo v4.2.0-246-ged9e9

Re: [PATCH] x86: Check for machine state object class before typecasting it

2019-12-30 Thread Philippe Mathieu-Daudé
On 12/30/19 10:35 AM, Michal Prívozník wrote: On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved from PC Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. This depends on how you format the hash :-) I

Re: [PATCH] x86: Check for machine state object class before typecasting it

2019-12-30 Thread Michal Prívozník
On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 9:00 AM, Michal Privoznik wrote: >> In v4.2.0-246-ged9e923c3c the SMM property was moved from PC > > Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. This depends on how you format the hash :-) I've used 'git describe ed9e923c3c' because

Re: [PATCH] x86: Check for machine state object class before typecasting it

2019-12-30 Thread Philippe Mathieu-Daudé
On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved from PC Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. machine class to x86 machine class. Makes sense, but the change was too aggressive: in target/i386/kvm.c:kvm_arch_init() it altered check which

Re: [PATCH] x86: Check for machine state object class before typecasting it

2019-12-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/7cc91bab3191bfd7e071bdd3fdf7fe2a2991deb0.1577692822.git.mpriv...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it l

[PATCH] x86: Check for machine state object class before typecasting it

2019-12-30 Thread Michal Privoznik
In v4.2.0-246-ged9e923c3c the SMM property was moved from PC machine class to x86 machine class. Makes sense, but the change was too aggressive: in target/i386/kvm.c:kvm_arch_init() it altered check which sets SMRAM if given machine has SMM enabled. The line that detects whether given machine objec