Re: [PATCH] vvfat: fix out of bounds array write

2025-01-22 Thread Michael Tokarev
22.01.2025 15:19, BALATON Zoltan wrote: On Wed, 22 Jan 2025, Michael Tokarev wrote: 22.01.2025 02:14, Pierrick Bouvier wrote: .. I agree the existing code (and this patch) is pretty cryptic for anyone not familiar with FAT format. However, I think it could be a good thing to first merge this o

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-22 Thread BALATON Zoltan
On Wed, 22 Jan 2025, Michael Tokarev wrote: 22.01.2025 02:14, Pierrick Bouvier wrote: .. I agree the existing code (and this patch) is pretty cryptic for anyone not familiar with FAT format. However, I think it could be a good thing to first merge this one (which is correct, and works), and ref

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-21 Thread Pierrick Bouvier
On 1/21/25 19:47, Michael Tokarev wrote: 22.01.2025 02:14, Pierrick Bouvier wrote: .. I agree the existing code (and this patch) is pretty cryptic for anyone not familiar with FAT format. However, I think it could be a good thing to first merge this one (which is correct, and works), and refac

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-21 Thread Michael Tokarev
22.01.2025 02:14, Pierrick Bouvier wrote: .. I agree the existing code (and this patch) is pretty cryptic for anyone not familiar with FAT format. However, I think it could be a good thing to first merge this one (which is correct, and works), and refactor this in a second time, so the current

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-21 Thread Pierrick Bouvier
On 1/18/25 09:10, Michael Tokarev wrote: 05.01.2025 16:59, Volker Rümelin wrote: In function create_long_filname(), the array name[8 + 3] in struct direntry_t is used as if it were defined as name[32]. This is intentional and works. It's nevertheless an out of bounds array access. To avoid this

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-18 Thread Michael Tokarev
05.01.2025 16:59, Volker Rümelin wrote: In function create_long_filname(), the array name[8 + 3] in struct direntry_t is used as if it were defined as name[32]. This is intentional and works. It's nevertheless an out of bounds array access. To avoid this problem, this patch adds a struct lfn_dire

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-09 Thread Pierrick Bouvier
Hi Volker, On 1/5/25 05:59, Volker Rümelin wrote: In function create_long_filname(), the array name[8 + 3] in struct direntry_t is used as if it were defined as name[32]. This is intentional and works. It's nevertheless an out of bounds array access. To avoid this problem, this patch adds a stru

[PATCH] vvfat: fix out of bounds array write

2025-01-05 Thread Volker Rümelin
In function create_long_filname(), the array name[8 + 3] in struct direntry_t is used as if it were defined as name[32]. This is intentional and works. It's nevertheless an out of bounds array access. To avoid this problem, this patch adds a struct lfn_direntry_t with multiple name arrays. A direct