Re: [PATCH] vl: change PID file path resolve error to warning

2022-10-28 Thread Fiona Ebner
Am 28.10.22 um 09:26 schrieb Thomas Lamprecht: > On 28/10/2022 09:11, Fiona Ebner wrote: >> Am 27.10.22 um 14:17 schrieb Daniel P. Berrangé: >>> On Thu, Oct 27, 2022 at 12:14:43PM +0200, Fiona Ebner wrote: +warn_report("not removing PID file on exit: cannot resolve PID file"

Re: [PATCH] vl: change PID file path resolve error to warning

2022-10-28 Thread Thomas Lamprecht
On 28/10/2022 09:11, Fiona Ebner wrote: > Am 27.10.22 um 14:17 schrieb Daniel P. Berrangé: >> On Thu, Oct 27, 2022 at 12:14:43PM +0200, Fiona Ebner wrote: >>> +warn_report("not removing PID file on exit: cannot resolve PID >>> file" >>> +" path: %s: %s", pid_fil

Re: [PATCH] vl: change PID file path resolve error to warning

2022-10-28 Thread Fiona Ebner
Am 27.10.22 um 14:17 schrieb Daniel P. Berrangé: > On Thu, Oct 27, 2022 at 12:14:43PM +0200, Fiona Ebner wrote: >> +warn_report("not removing PID file on exit: cannot resolve PID >> file" >> +" path: %s: %s", pid_file, strerror(errno)); >> +return; >

Re: [PATCH] vl: change PID file path resolve error to warning

2022-10-27 Thread Daniel P . Berrangé
On Thu, Oct 27, 2022 at 12:14:43PM +0200, Fiona Ebner wrote: > Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") made it a > critical error when the PID file path cannot be resolved. Before this > commit, it was possible to invoke QEMU when the PID file was a file > created with mkstemp that

Re: [PATCH] vl: change PID file path resolve error to warning

2022-10-27 Thread Hanna Reitz
On 27.10.22 12:14, Fiona Ebner wrote: Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") made it a critical error when the PID file path cannot be resolved. Before this commit, it was possible to invoke QEMU when the PID file was a file created with mkstemp that was already unlinked at the t

[PATCH] vl: change PID file path resolve error to warning

2022-10-27 Thread Fiona Ebner
Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") made it a critical error when the PID file path cannot be resolved. Before this commit, it was possible to invoke QEMU when the PID file was a file created with mkstemp that was already unlinked at the time of the invocation. There might be ot