Re: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-18 Thread Max Reitz
On 12.02.21 19:58, Cleber Rosa wrote: On Fri, Feb 12, 2021 at 04:16:49PM +0100, Max Reitz wrote: From the cancel message, it is not entirely clear why this parameter is mandatory now, or that it will be optional in the future. Add such a more detailed explanation as a comment in the test sourc

Re: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-15 Thread Cleber Rosa
On Fri, Feb 12, 2021 at 09:42:24PM +0100, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > > > Hi Max, > > > > This looks good to me, and I've also tested your kernel build and > > works like a charm. > > > > As further work on top of this, it may be beneficial to have test > > documentation in a

Re: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-15 Thread Cleber Rosa
On Fri, Feb 12, 2021 at 04:16:49PM +0100, Max Reitz wrote: > From the cancel message, it is not entirely clear why this parameter is > mandatory now, or that it will be optional in the future. Add such a > more detailed explanation as a comment in the test source file. > > Suggested-by: Alex Benn

Re: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-12 Thread Alex Bennée
Max Reitz writes: > From the cancel message, it is not entirely clear why this parameter is > mandatory now, or that it will be optional in the future. Add such a > more detailed explanation as a comment in the test source file. > > Suggested-by: Alex Bennée > Signed-off-by: Max Reitz Than

Re: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-12 Thread Willian Rampazzo
On Fri, Feb 12, 2021 at 12:20 PM Max Reitz wrote: > > From the cancel message, it is not entirely clear why this parameter is > mandatory now, or that it will be optional in the future. Add such a > more detailed explanation as a comment in the test source file. > > Suggested-by: Alex Bennée > S

Re: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-12 Thread Philippe Mathieu-Daudé
Hi Cleber, On 2/12/21 7:58 PM, Cleber Rosa wrote: > On Fri, Feb 12, 2021 at 04:16:49PM +0100, Max Reitz wrote: >> From the cancel message, it is not entirely clear why this parameter is >> mandatory now, or that it will be optional in the future. Add such a >> more detailed explanation as a comme

Re: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-12 Thread Cleber Rosa
On Fri, Feb 12, 2021 at 04:16:49PM +0100, Max Reitz wrote: > From the cancel message, it is not entirely clear why this parameter is > mandatory now, or that it will be optional in the future. Add such a > more detailed explanation as a comment in the test source file. > > Suggested-by: Alex Benn

[PATCH] virtiofs_submounts.py test: Note on vmlinuz param

2021-02-12 Thread Max Reitz
>From the cancel message, it is not entirely clear why this parameter is mandatory now, or that it will be optional in the future. Add such a more detailed explanation as a comment in the test source file. Suggested-by: Alex Bennée Signed-off-by: Max Reitz --- I’ve uploaded a build of Linux 5.1