Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-23 Thread Gerd Hoffmann
Hi, > Just a question, why didn't we choose the virtio-vga order to avoid > shuffling from the beginning? Vga came after and we keep the > compatibility ? Well, transitional virtio devices need bar 0 for legacy virtio compatibility (io bar), so using bar 1 for msix makes sense in that case. vi

Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-22 Thread Anthoine Bourgeois
On Wed, Apr 22, 2020 at 12:46:57PM +0200, Gerd Hoffmann wrote: This fix exchange the modern io bar with the modern memory bar, replacing the msix bar that is never impacted anyway. Well, msix was placed in bar 4 intentionally. That keeps bar 1 (default msix location) free, so we have the optio

Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-22 Thread Michael S. Tsirkin
On Wed, Apr 22, 2020 at 12:49:41PM +0200, Gerd Hoffmann wrote: > On Wed, Apr 22, 2020 at 02:04:36AM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 21, 2020 at 11:48:53PM +0200, Anthoine Bourgeois wrote: > > > With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility > > > with stdv

Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-22 Thread Gerd Hoffmann
On Wed, Apr 22, 2020 at 02:04:36AM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 21, 2020 at 11:48:53PM +0200, Anthoine Bourgeois wrote: > > With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility > > with stdvga. By default, bar #2 is used by virtio modern io bar. > > This bar is

Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-22 Thread Gerd Hoffmann
> This fix exchange the modern io bar with the modern memory bar, > replacing the msix bar that is never impacted anyway. Well, msix was placed in bar 4 intentionally. That keeps bar 1 (default msix location) free, so we have the option to turn bar 0 (vga compat vram) into a 64bit bar without shu

Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2020 at 11:48:53PM +0200, Anthoine Bourgeois wrote: > With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility > with stdvga. By default, bar #2 is used by virtio modern io bar. > This bar is the last one introduce in the virtio pci bar layout and it's > crushed by t

[PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-21 Thread Anthoine Bourgeois
With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility with stdvga. By default, bar #2 is used by virtio modern io bar. This bar is the last one introduce in the virtio pci bar layout and it's crushed by the virtio-vga reordering. So virtio-vga and modern-pio-notify are incompatib