Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 11:07:11AM +0200, Laurent Vivier wrote: > On 24/07/2024 12:51, Michael S. Tsirkin wrote: > > with max-bytes set to 0, quota is 0 and so device does not work. > > block this to avoid user confusion > > > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/virtio/virtio-rng

Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-30 Thread Laurent Vivier
On 24/07/2024 12:51, Michael S. Tsirkin wrote: with max-bytes set to 0, quota is 0 and so device does not work. block this to avoid user confusion Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-rng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio/v

Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 12:51, Michael S. Tsirkin wrote: with max-bytes set to 0, quota is 0 and so device does not work. block this to avoid user confusion Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-rng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Philippe Math

Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-24 Thread Amit Shah
On Wed, 2024-07-24 at 06:51 -0400, Michael S. Tsirkin wrote: > with max-bytes set to 0, quota is 0 and so device does not work. > block this to avoid user confusion > > Signed-off-by: Michael S. Tsirkin > --- >  hw/virtio/virtio-rng.c | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) >

Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-24 Thread Laurent Vivier
On 24/07/2024 12:51, Michael S. Tsirkin wrote: with max-bytes set to 0, quota is 0 and so device does not work. block this to avoid user confusion Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-rng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio/v

[PATCH] virtio-rng: block max-bytes=0

2024-07-24 Thread Michael S. Tsirkin
with max-bytes set to 0, quota is 0 and so device does not work. block this to avoid user confusion Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-rng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index f74efffe