Re: [PATCH] virtio-pci: fix virtio_pci_queue_enabled()

2020-07-29 Thread Michael S. Tsirkin
On Tue, Jul 28, 2020 at 11:55:16AM +0800, Jason Wang wrote: > > On 2020/7/27 下午11:33, Laurent Vivier wrote: > > In legacy mode, virtio_pci_queue_enabled() falls back to > > virtio_queue_enabled() to know if the queue is enabled. > > > > But virtio_queue_enabled() calls again virtio_pci_queue_enab

Re: [PATCH] virtio-pci: fix virtio_pci_queue_enabled()

2020-07-27 Thread Jason Wang
On 2020/7/27 下午11:33, Laurent Vivier wrote: In legacy mode, virtio_pci_queue_enabled() falls back to virtio_queue_enabled() to know if the queue is enabled. But virtio_queue_enabled() calls again virtio_pci_queue_enabled() if k->queue_enabled is set. This ends in a crash after a stack overflow

Re: [PATCH] virtio-pci: fix virtio_pci_queue_enabled()

2020-07-27 Thread Richard Henderson
On 7/27/20 8:33 AM, Laurent Vivier wrote: > In legacy mode, virtio_pci_queue_enabled() falls back to > virtio_queue_enabled() to know if the queue is enabled. > > But virtio_queue_enabled() calls again virtio_pci_queue_enabled() > if k->queue_enabled is set. This ends in a crash after a stack > ov

[PATCH] virtio-pci: fix virtio_pci_queue_enabled()

2020-07-27 Thread Laurent Vivier
In legacy mode, virtio_pci_queue_enabled() falls back to virtio_queue_enabled() to know if the queue is enabled. But virtio_queue_enabled() calls again virtio_pci_queue_enabled() if k->queue_enabled is set. This ends in a crash after a stack overflow. The problem can be reproduced with "-device v