Re: [PATCH] virtio-pci: fix up config interrupt handling

2022-01-10 Thread Michael S. Tsirkin
On Mon, Jan 10, 2022 at 08:37:43PM +, Marc Zyngier wrote: > Hi Michael, > > On Sun, 09 Jan 2022 17:49:19 +, > "Michael S. Tsirkin" wrote: > > > > Fixes a couple of issues with irqfd use by config interrupt: > > - Rearrange initialization so cleanup happens in the reverse order > > - Don'

Re: [PATCH] virtio-pci: fix up config interrupt handling

2022-01-10 Thread Marc Zyngier
Hi Michael, On Sun, 09 Jan 2022 17:49:19 +, "Michael S. Tsirkin" wrote: > > Fixes a couple of issues with irqfd use by config interrupt: > - Rearrange initialization so cleanup happens in the reverse order > - Don't use irqfd for config when not in use for data path > I am not sure this is a

Re: [PATCH] virtio-pci: fix up config interrupt handling

2022-01-09 Thread Cédric Le Goater
On 1/9/22 18:49, Michael S. Tsirkin wrote: Fixes a couple of issues with irqfd use by config interrupt: - Rearrange initialization so cleanup happens in the reverse order - Don't use irqfd for config when not in use for data path I am not sure this is a complete fix though: I think we are better

[PATCH] virtio-pci: fix up config interrupt handling

2022-01-09 Thread Michael S. Tsirkin
Fixes a couple of issues with irqfd use by config interrupt: - Rearrange initialization so cleanup happens in the reverse order - Don't use irqfd for config when not in use for data path I am not sure this is a complete fix though: I think we are better off limiting the effect to vdpa devices with