Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-09 Thread Eugenio Perez Martin
On Mon, May 8, 2023 at 8:11 PM Michael S. Tsirkin wrote: > > On Mon, May 08, 2023 at 07:31:35PM +0200, Eugenio Perez Martin wrote: > > On Mon, May 8, 2023 at 12:22 PM Michael S. Tsirkin wrote: > > > > > > On Mon, May 08, 2023 at 11:09:46AM +0200, Eugenio Perez Martin wrote: > > > > On Sat, May 6,

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-08 Thread Jason Wang
On Tue, May 9, 2023 at 1:32 AM Eugenio Perez Martin wrote: > > On Mon, May 8, 2023 at 12:22 PM Michael S. Tsirkin wrote: > > > > On Mon, May 08, 2023 at 11:09:46AM +0200, Eugenio Perez Martin wrote: > > > On Sat, May 6, 2023 at 4:25 AM Xuan Zhuo > > > wrote: > > > > > > > > On Thu, 4 May 2023

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-08 Thread Michael S. Tsirkin
On Mon, May 08, 2023 at 07:31:35PM +0200, Eugenio Perez Martin wrote: > On Mon, May 8, 2023 at 12:22 PM Michael S. Tsirkin wrote: > > > > On Mon, May 08, 2023 at 11:09:46AM +0200, Eugenio Perez Martin wrote: > > > On Sat, May 6, 2023 at 4:25 AM Xuan Zhuo > > > wrote: > > > > > > > > On Thu, 4 M

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-08 Thread Eugenio Perez Martin
On Mon, May 8, 2023 at 12:22 PM Michael S. Tsirkin wrote: > > On Mon, May 08, 2023 at 11:09:46AM +0200, Eugenio Perez Martin wrote: > > On Sat, May 6, 2023 at 4:25 AM Xuan Zhuo wrote: > > > > > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > > > wrote: > > > > The commit

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-08 Thread Michael S. Tsirkin
On Mon, May 08, 2023 at 11:09:46AM +0200, Eugenio Perez Martin wrote: > On Sat, May 6, 2023 at 4:25 AM Xuan Zhuo wrote: > > > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > > wrote: > > > The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables > > > uncond

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-08 Thread Xuan Zhuo
On Mon, 8 May 2023 11:09:46 +0200, Eugenio Perez Martin wrote: > On Sat, May 6, 2023 at 4:25 AM Xuan Zhuo wrote: > > > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > > wrote: > > > The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables > > > uncondition

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-08 Thread Eugenio Perez Martin
On Sat, May 6, 2023 at 4:25 AM Xuan Zhuo wrote: > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > wrote: > > The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables > > unconditionally vq reset feature as long as the device is emulated. > > This makes impos

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-08 Thread Xuan Zhuo
On Mon, 8 May 2023 14:44:21 +0800, Jason Wang wrote: > On Sun, May 7, 2023 at 2:01 PM Michael S. Tsirkin wrote: > > > > On Sat, May 06, 2023 at 10:13:36AM +0800, Xuan Zhuo wrote: > > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > > > wrote: > > > > The commit 93a97dc5200

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-07 Thread Michael S. Tsirkin
On Mon, May 08, 2023 at 02:44:21PM +0800, Jason Wang wrote: > On Sun, May 7, 2023 at 2:01 PM Michael S. Tsirkin wrote: > > > > On Sat, May 06, 2023 at 10:13:36AM +0800, Xuan Zhuo wrote: > > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > > > wrote: > > > > The commit 93a97

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-07 Thread Jason Wang
On Sun, May 7, 2023 at 2:01 PM Michael S. Tsirkin wrote: > > On Sat, May 06, 2023 at 10:13:36AM +0800, Xuan Zhuo wrote: > > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > > wrote: > > > The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables > > > unconditio

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-06 Thread Michael S. Tsirkin
On Sat, May 06, 2023 at 10:13:36AM +0800, Xuan Zhuo wrote: > On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= > wrote: > > The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables > > unconditionally vq reset feature as long as the device is emulated. > > This mak

Re: [PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-05 Thread Xuan Zhuo
On Thu, 4 May 2023 12:14:47 +0200, =?utf-8?q?Eugenio_P=C3=A9rez?= wrote: > The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables > unconditionally vq reset feature as long as the device is emulated. > This makes impossible to actually disable the feature, and it causes > migrat

[PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-04 Thread Eugenio Pérez
The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables unconditionally vq reset feature as long as the device is emulated. This makes impossible to actually disable the feature, and it causes migration problems from qemu version previous than 7.2. The entire final commit is unneed