Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-05-05 Thread Jason Wang
在 2021/5/5 下午3:46, Laurent Vivier 写道: On 29/04/2021 09:26, Jason Wang wrote: 在 2021/4/28 下午6:14, Michael S. Tsirkin 写道: On Tue, Apr 27, 2021 at 03:02:34PM +0100, Dr. David Alan Gilbert wrote: * Laurent Vivier (lviv...@redhat.com) wrote: In the failover case configuration, virtio_net_device_

Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-05-05 Thread Laurent Vivier
On 29/04/2021 09:26, Jason Wang wrote: > > 在 2021/4/28 下午6:14, Michael S. Tsirkin 写道: >> On Tue, Apr 27, 2021 at 03:02:34PM +0100, Dr. David Alan Gilbert wrote: >>> * Laurent Vivier (lviv...@redhat.com) wrote: In the failover case configuration, virtio_net_device_realize() uses an add_mi

Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-04-29 Thread Jason Wang
在 2021/4/28 下午6:14, Michael S. Tsirkin 写道: On Tue, Apr 27, 2021 at 03:02:34PM +0100, Dr. David Alan Gilbert wrote: * Laurent Vivier (lviv...@redhat.com) wrote: In the failover case configuration, virtio_net_device_realize() uses an add_migration_state_change_notifier() to add a state notifier

Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-04-28 Thread Michael S. Tsirkin
On Tue, Apr 27, 2021 at 03:02:34PM +0100, Dr. David Alan Gilbert wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: > > In the failover case configuration, virtio_net_device_realize() uses an > > add_migration_state_change_notifier() to add a state notifier, but this > > notifier is not removed

Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-04-27 Thread Jason Wang
在 2021/4/27 下午9:51, Laurent Vivier 写道: In the failover case configuration, virtio_net_device_realize() uses an add_migration_state_change_notifier() to add a state notifier, but this notifier is not removed by the unrealize function when the virtio-net card is unplugged. If the card is unplugg

Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-04-27 Thread Philippe Mathieu-Daudé
On 4/27/21 4:02 PM, Dr. David Alan Gilbert wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: >> In the failover case configuration, virtio_net_device_realize() uses an >> add_migration_state_change_notifier() to add a state notifier, but this >> notifier is not removed by the unrealize function

Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-04-27 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > In the failover case configuration, virtio_net_device_realize() uses an > add_migration_state_change_notifier() to add a state notifier, but this > notifier is not removed by the unrealize function when the virtio-net > card is unplugged. > > If the c

[PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-04-27 Thread Laurent Vivier
In the failover case configuration, virtio_net_device_realize() uses an add_migration_state_change_notifier() to add a state notifier, but this notifier is not removed by the unrealize function when the virtio-net card is unplugged. If the card is unplugged and a migration is started, the notifier