Re: RE: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request

2023-05-09 Thread Mauro Matteo Cascella
>> To: qemu-devel@nongnu.org > >> Cc: m...@redhat.com; Gonglei (Arei) ; > >> pizhen...@bytedance.com; ta...@zju.edu.cn; mcasc...@redhat.com > >> Subject: [PATCH] virtio-crypto: fix NULL pointer dereference in > >> virtio_crypto_free_request > >> >

Re: RE: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request

2023-05-08 Thread zhenwei pi
Subject: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM algtype. Fixes: 02ed3e7c ("virtio-crypto: zeroize the key material before free") I have to say the fixes is incorrect. The bug was int

RE: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request

2023-05-08 Thread Gonglei (Arei)
H] virtio-crypto: fix NULL pointer dereference in > virtio_crypto_free_request > > Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM > algtype. > > Fixes: 02ed3e7c ("virtio-crypto: zeroize the key material before free") I have to say the fixes is incorre

[PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request

2023-05-08 Thread Mauro Matteo Cascella
Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM algtype. Fixes: 02ed3e7c ("virtio-crypto: zeroize the key material before free") Signed-off-by: Mauro Matteo Cascella Reported-by: Yiming Tao --- hw/virtio/virtio-crypto.c | 20 +++- 1 file changed, 11 insertions(+