Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-10 Thread Daniel P . Berrangé
On Tue, Jun 10, 2025 at 12:41:00PM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > > stack for exploits") the -ftrivial-auto-var-init=zero compiler option is > > used to

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-10 Thread Michael S. Tsirkin
On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > stack for exploits") the -ftrivial-auto-var-init=zero compiler option is > used to zero local variables. While this reduces security risks > associated with u

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-06 Thread Kevin Wolf
Am 05.06.2025 um 20:54 hat Daniel P. Berrangé geschrieben: > On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > > stack for exploits") the -ftrivial-auto-var-init=zero compiler option is > > used to zero loc

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-05 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > stack for exploits") the -ftrivial-auto-var-init=zero compiler option is > used to zero local variables. While this reduces security risks > associated with u

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-05 Thread Peter Maydell
On Thu, 5 Jun 2025 at 17:18, Philippe Mathieu-Daudé wrote: > > On 5/6/25 14:50, Stefan Hajnoczi wrote: > > On Thu, Jun 05, 2025 at 01:28:49PM +0200, Philippe Mathieu-Daudé wrote: > >> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > >> index 85110bce374..b96c6ec603c 100644 > >> --- a/hw/virt

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-05 Thread Philippe Mathieu-Daudé
On 5/6/25 14:50, Stefan Hajnoczi wrote: On Thu, Jun 05, 2025 at 01:28:49PM +0200, Philippe Mathieu-Daudé wrote: On 5/6/25 10:34, Daniel P. Berrangé wrote: On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize st

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2025 at 01:28:49PM +0200, Philippe Mathieu-Daudé wrote: > On 5/6/25 10:34, Daniel P. Berrangé wrote: > > On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > > > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > > > stack for exploits") the -ftr

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2025 at 09:34:01AM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > > stack for exploits") the -ftrivial-auto-var-init=zero compiler option is > > used to

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-05 Thread Philippe Mathieu-Daudé
On 5/6/25 10:34, Daniel P. Berrangé wrote: On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize stack for exploits") the -ftrivial-auto-var-init=zero compiler option is used to zero local variables. While this re

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-05 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > stack for exploits") the -ftrivial-auto-var-init=zero compiler option is > used to zero local variables. While this reduces security risks > associated with u

[PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-04 Thread Stefan Hajnoczi
Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize stack for exploits") the -ftrivial-auto-var-init=zero compiler option is used to zero local variables. While this reduces security risks associated with uninitialized stack data, it introduced a measurable bottleneck in the vir