Re: [PATCH] virtio: Call set_features during reset

2025-04-21 Thread Akihiko Odaki
On 2025/04/10 18:32, Philippe Mathieu-Daudé wrote: Hi Akihiko, On 10/4/25 09:42, Akihiko Odaki wrote: virtio-net expects set_features() will be called when the feature set used by the guest changes to update the number of virtqueues. Call it during reset as reset clears all features and the que

Re: [PATCH] virtio: Call set_features during reset

2025-04-18 Thread Akihiko Odaki
On 2025/04/16 14:46, Jason Wang wrote: On Thu, Apr 10, 2025 at 3:42 PM Akihiko Odaki wrote: virtio-net expects set_features() will be called when the feature set used by the guest changes to update the number of virtqueues. Call it during reset as reset clears all features and the queues added

Re: [PATCH] virtio: Call set_features during reset

2025-04-15 Thread Jason Wang
On Thu, Apr 10, 2025 at 3:42 PM Akihiko Odaki wrote: > > virtio-net expects set_features() will be called when the feature set > used by the guest changes to update the number of virtqueues. Call it > during reset as reset clears all features and the queues added for > VIRTIO_NET_F_MQ or VIRTIO_NE

Re: [PATCH] virtio: Call set_features during reset

2025-04-10 Thread Akihiko Odaki
On 2025/04/10 22:45, Michael S. Tsirkin wrote: On Thu, Apr 10, 2025 at 05:26:47PM +0900, Akihiko Odaki wrote: On 2025/04/10 17:02, Michael S. Tsirkin wrote: On Thu, Apr 10, 2025 at 04:54:41PM +0900, Akihiko Odaki wrote: On 2025/04/10 16:48, 'Michael S. Tsirkin' via devel wrote: On Thu, Apr 10

Re: [PATCH] virtio: Call set_features during reset

2025-04-10 Thread Akihiko Odaki
On 2025/04/10 16:48, 'Michael S. Tsirkin' via devel wrote: On Thu, Apr 10, 2025 at 04:42:06PM +0900, Akihiko Odaki wrote: virtio-net expects set_features() will be called when the feature set used by the guest changes to update the number of virtqueues. Call it during reset as reset clears all f

Re: [PATCH] virtio: Call set_features during reset

2025-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2025 at 05:26:47PM +0900, Akihiko Odaki wrote: > On 2025/04/10 17:02, Michael S. Tsirkin wrote: > > On Thu, Apr 10, 2025 at 04:54:41PM +0900, Akihiko Odaki wrote: > > > On 2025/04/10 16:48, 'Michael S. Tsirkin' via devel wrote: > > > > On Thu, Apr 10, 2025 at 04:42:06PM +0900, Akihi

Re: [PATCH] virtio: Call set_features during reset

2025-04-10 Thread Philippe Mathieu-Daudé
Hi Akihiko, On 10/4/25 09:42, Akihiko Odaki wrote: virtio-net expects set_features() will be called when the feature set used by the guest changes to update the number of virtqueues. Call it during reset as reset clears all features and the queues added for VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS wi

Re: [PATCH] virtio: Call set_features during reset

2025-04-10 Thread Akihiko Odaki
On 2025/04/10 17:02, Michael S. Tsirkin wrote: On Thu, Apr 10, 2025 at 04:54:41PM +0900, Akihiko Odaki wrote: On 2025/04/10 16:48, 'Michael S. Tsirkin' via devel wrote: On Thu, Apr 10, 2025 at 04:42:06PM +0900, Akihiko Odaki wrote: virtio-net expects set_features() will be called when the feat

Re: [PATCH] virtio: Call set_features during reset

2025-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2025 at 04:54:41PM +0900, Akihiko Odaki wrote: > On 2025/04/10 16:48, 'Michael S. Tsirkin' via devel wrote: > > On Thu, Apr 10, 2025 at 04:42:06PM +0900, Akihiko Odaki wrote: > > > virtio-net expects set_features() will be called when the feature set > > > used by the guest changes

Re: [PATCH] virtio: Call set_features during reset

2025-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2025 at 04:42:06PM +0900, Akihiko Odaki wrote: > virtio-net expects set_features() will be called when the feature set > used by the guest changes to update the number of virtqueues. Call it > during reset as reset clears all features and the queues added for > VIRTIO_NET_F_MQ or VI

[PATCH] virtio: Call set_features during reset

2025-04-10 Thread Akihiko Odaki
virtio-net expects set_features() will be called when the feature set used by the guest changes to update the number of virtqueues. Call it during reset as reset clears all features and the queues added for VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS will need to be removed. Fixes: f9d6dbf0bf6e ("virtio-n