Re: [PATCH] virito: Use auto rcu_read macros

2019-10-28 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Mon, Oct 14, 2019 at 06:54:40PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD > > to replace the manual rcu_read_(un)lock calls. > > > > I think the onl

Re: [PATCH] virito: Use auto rcu_read macros

2019-10-25 Thread Michael S. Tsirkin
On Mon, Oct 14, 2019 at 06:54:40PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD > to replace the manual rcu_read_(un)lock calls. > > I think the only change is virtio_load which was missing unlocks > in error

Re: [PATCH] virito: Use auto rcu_read macros

2019-10-16 Thread Stefan Hajnoczi
On Mon, Oct 14, 2019 at 06:54:40PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD > to replace the manual rcu_read_(un)lock calls. > > I think the only change is virtio_load which was missing unlocks > in error

Re: [PATCH] virito: Use auto rcu_read macros

2019-10-14 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD > to replace the manual rcu_read_(un)lock calls. > > I think the only change is virtio_load which was missing unlocks > in error paths; those end

[PATCH] virito: Use auto rcu_read macros

2019-10-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD to replace the manual rcu_read_(un)lock calls. I think the only change is virtio_load which was missing unlocks in error paths; those end up being fatal errors so it's not that important anyway. Signed-off-by: D