Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-22 Thread Stefan Hajnoczi
On Mon, Oct 21, 2019 at 08:19:59AM +, Liu, Changpeng wrote: > There is some logic in vhost_user_blk_handle_output() for now, it's not empty > as vhost-user-scsi. The purpose of the vhost_user_blk_handle_output() code is to deal with legacy drivers that violate the VIRTIO spec by accessing vir

Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-21 Thread Stefan Hajnoczi
On Thu, Oct 17, 2019 at 04:39:44PM +, Felipe Franciosi wrote: > Originally, vhost-user-scsi did not implement a handle_output callback > as that didn't seem necessary. Turns out it is. > > Depending on which other devices are presented to a VM, SeaBIOS may > decide to map vhost-user-scsi devic

Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-21 Thread Yongji Xie
On Mon, 21 Oct 2019 at 16:20, Liu, Changpeng wrote: > > There is some logic in vhost_user_blk_handle_output() for now, it's not empty > as vhost-user-scsi. > There should be other issue if it can't start from SeaBIOS. > No, it's the same issue. We can see the notify is triggered from the VIRTIO_

Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-21 Thread Yongji Xie
On Mon, 21 Oct 2019 at 16:00, Felipe Franciosi wrote: > > > > > On Oct 21, 2019, at 5:01 AM, Yongji Xie wrote: > > > > On Fri, 18 Oct 2019 at 19:14, Felipe Franciosi wrote: > >> > >> > >> > >>> On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote: > >>> > >>> On Fri, 18 Oct 2019 at 01:17, Felipe Franc

RE: [PATCH] vhost-user-scsi: implement handle_output

2019-10-21 Thread Liu, Changpeng
:00 PM > To: Yongji Xie ; Liu, Changpeng > > Cc: Stefan Hajnoczi ; Alex Williamson > ; Dr . David Alan Gilbert ; > qemu-devel@nongnu.org > Subject: Re: [PATCH] vhost-user-scsi: implement handle_output > > > > > On Oct 21, 2019, at 5:01 AM, Yongji Xie wrote: &g

Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-21 Thread Felipe Franciosi
> On Oct 21, 2019, at 5:01 AM, Yongji Xie wrote: > > On Fri, 18 Oct 2019 at 19:14, Felipe Franciosi wrote: >> >> >> >>> On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote: >>> >>> On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote: Originally, vhost-user-scsi did not implement a

Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-20 Thread Yongji Xie
On Fri, 18 Oct 2019 at 19:14, Felipe Franciosi wrote: > > > > > On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote: > > > > On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote: > >> > >> Originally, vhost-user-scsi did not implement a handle_output callback > >> as that didn't seem necessary. Turns

Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-18 Thread Felipe Franciosi
> On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote: > > On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote: >> >> Originally, vhost-user-scsi did not implement a handle_output callback >> as that didn't seem necessary. Turns out it is. >> >> Depending on which other devices are presented to

Re: [PATCH] vhost-user-scsi: implement handle_output

2019-10-17 Thread Yongji Xie
On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote: > > Originally, vhost-user-scsi did not implement a handle_output callback > as that didn't seem necessary. Turns out it is. > > Depending on which other devices are presented to a VM, SeaBIOS may > decide to map vhost-user-scsi devices on the

[PATCH] vhost-user-scsi: implement handle_output

2019-10-17 Thread Felipe Franciosi
Originally, vhost-user-scsi did not implement a handle_output callback as that didn't seem necessary. Turns out it is. Depending on which other devices are presented to a VM, SeaBIOS may decide to map vhost-user-scsi devices on the 64-bit range of the address space. As a result, SeaBIOS will kick