Re: [PATCH] vhost-user-scsi: avoid unlink(NULL) with fd passing

2022-05-16 Thread Stefan Hajnoczi
On Thu, May 12, 2022 at 04:57:13PM +0100, Peter Maydell wrote: > On Wed, 27 Apr 2022 at 11:04, Stefan Hajnoczi wrote: > > > > Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend > > Program conventions for vhost-user-scsi") introduced fd-passing support > > as part of implementing

Re: [PATCH] vhost-user-scsi: avoid unlink(NULL) with fd passing

2022-05-13 Thread Michael S. Tsirkin
On Thu, May 12, 2022 at 04:57:13PM +0100, Peter Maydell wrote: > On Wed, 27 Apr 2022 at 11:04, Stefan Hajnoczi wrote: > > > > Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend > > Program conventions for vhost-user-scsi") introduced fd-passing support > > as part of implementing

Re: [PATCH] vhost-user-scsi: avoid unlink(NULL) with fd passing

2022-05-12 Thread Peter Maydell
On Wed, 27 Apr 2022 at 11:04, Stefan Hajnoczi wrote: > > Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend > Program conventions for vhost-user-scsi") introduced fd-passing support > as part of implementing the vhost-user backend program conventions. > > When fd passing is used

Re: [PATCH] vhost-user-scsi: avoid unlink(NULL) with fd passing

2022-05-09 Thread Philippe Mathieu-Daudé via
On 27/4/22 12:01, Stefan Hajnoczi wrote: Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend Program conventions for vhost-user-scsi") introduced fd-passing support as part of implementing the vhost-user backend program conventions. When fd passing is used the UNIX domain socket

Re: [PATCH] vhost-user-scsi: avoid unlink(NULL) with fd passing

2022-04-29 Thread Raphael Norwitz
On Wed, Apr 27, 2022 at 11:01:16AM +0100, Stefan Hajnoczi wrote: > Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend > Program conventions for vhost-user-scsi") introduced fd-passing support > as part of implementing the vhost-user backend program conventions. > > When fd passin

[PATCH] vhost-user-scsi: avoid unlink(NULL) with fd passing

2022-04-27 Thread Stefan Hajnoczi
Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend Program conventions for vhost-user-scsi") introduced fd-passing support as part of implementing the vhost-user backend program conventions. When fd passing is used the UNIX domain socket path is NULL and we must not call unlink(2