Re: [PATCH] vhost-user: fix shared object return values

2024-10-21 Thread Albert Esteve
On Thu, Oct 17, 2024 at 11:38 AM Stefano Garzarella wrote: > > On Thu, Oct 17, 2024 at 10:27:30AM +0200, Albert Esteve wrote: > >Albert Esteve > > > >Senior Software Engineer > > > >Red Hat > > > >aest...@redhat.com > > > > > > > >On Thu, Oct 17, 2024 at 9:38 AM Stefano Garzarella > >wrote: > >>

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Stefano Garzarella
On Thu, Oct 17, 2024 at 10:27:30AM +0200, Albert Esteve wrote: Albert Esteve Senior Software Engineer Red Hat aest...@redhat.com On Thu, Oct 17, 2024 at 9:38 AM Stefano Garzarella wrote: On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: >VHOST_USER_BACKEND_SHARED_OBJECT_ADD

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 11:28:56AM +0200, Albert Esteve wrote: > On Thu, Oct 17, 2024 at 11:18 AM Daniel P. Berrangé > wrote: > > > > On Thu, Oct 17, 2024 at 11:12:32AM +0200, Albert Esteve wrote: > > > On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Wed, Oct

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Albert Esteve
On Thu, Oct 17, 2024 at 11:18 AM Daniel P. Berrangé wrote: > > On Thu, Oct 17, 2024 at 11:12:32AM +0200, Albert Esteve wrote: > > On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > > > > VHOST_USER_BACKEND_S

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 11:12:32AM +0200, Albert Esteve wrote: > On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé > wrote: > > > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > > > VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > > > VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state >

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Albert Esteve
On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé wrote: > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > > VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > > VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state > > in the spec that they return 0 for successful > > operations, non-zero ot

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state > in the spec that they return 0 for successful > operations, non-zero otherwise. However, > implementation relies on the return types > of the v

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Albert Esteve
Albert Esteve Senior Software Engineer Red Hat aest...@redhat.com On Thu, Oct 17, 2024 at 9:38 AM Stefano Garzarella wrote: > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > >VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > >VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state > >in th

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Stefano Garzarella
On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: VHOST_USER_BACKEND_SHARED_OBJECT_ADD and VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state in the spec that they return 0 for successful operations, non-zero otherwise. However, implementation relies on the return types of the virtio-dmab

[PATCH] vhost-user: fix shared object return values

2024-10-16 Thread Albert Esteve
VHOST_USER_BACKEND_SHARED_OBJECT_ADD and VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state in the spec that they return 0 for successful operations, non-zero otherwise. However, implementation relies on the return types of the virtio-dmabuf library, with opposite semantics (true if everything is correc