Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-30 Thread Michael S. Tsirkin
On Mon, Sep 28, 2020 at 09:17:31PM +0800, Jiajun Chen wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is u

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-21 Thread Igor Mammedov
On Wed, 14 Oct 2020 12:11:34 -0400 Raphael Norwitz wrote: > On Wed, Oct 14, 2020 at 3:08 AM Michael S. Tsirkin wrote: > > > > On Tue, Oct 13, 2020 at 08:58:59PM -0400, Raphael Norwitz wrote: > > > On Tue, Oct 6, 2020 at 5:48 AM Igor Mammedov wrote: > > > > > > > > > > > On Mon, 28 Sep 2020

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2020 at 01:21:39PM -0400, Raphael Norwitz wrote: > On Wed, Oct 14, 2020 at 12:26 PM Michael S. Tsirkin wrote: > > > > On Wed, Oct 14, 2020 at 12:11:34PM -0400, Raphael Norwitz wrote: > > > On Wed, Oct 14, 2020 at 3:08 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Oct

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-14 Thread Raphael Norwitz
On Wed, Oct 14, 2020 at 12:26 PM Michael S. Tsirkin wrote: > > On Wed, Oct 14, 2020 at 12:11:34PM -0400, Raphael Norwitz wrote: > > On Wed, Oct 14, 2020 at 3:08 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Oct 13, 2020 at 08:58:59PM -0400, Raphael Norwitz wrote: > > > > On Tue, Oct 6, 2020 at

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2020 at 12:11:34PM -0400, Raphael Norwitz wrote: > On Wed, Oct 14, 2020 at 3:08 AM Michael S. Tsirkin wrote: > > > > On Tue, Oct 13, 2020 at 08:58:59PM -0400, Raphael Norwitz wrote: > > > On Tue, Oct 6, 2020 at 5:48 AM Igor Mammedov wrote: > > > > > > > > On Mon, 28 Sep 2020 21:17

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-14 Thread Raphael Norwitz
On Wed, Oct 14, 2020 at 3:08 AM Michael S. Tsirkin wrote: > > On Tue, Oct 13, 2020 at 08:58:59PM -0400, Raphael Norwitz wrote: > > On Tue, Oct 6, 2020 at 5:48 AM Igor Mammedov wrote: > > > > > > On Mon, 28 Sep 2020 21:17:31 +0800 > > > Jiajun Chen wrote: > > > > > > > Used_memslots is equal to d

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-14 Thread Michael S. Tsirkin
On Tue, Oct 13, 2020 at 08:58:59PM -0400, Raphael Norwitz wrote: > On Tue, Oct 6, 2020 at 5:48 AM Igor Mammedov wrote: > > > > On Mon, 28 Sep 2020 21:17:31 +0800 > > Jiajun Chen wrote: > > > > > Used_memslots is equal to dev->mem->nregions now, it is true for > > > vhost kernel, but not for vhost

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-13 Thread Raphael Norwitz
On Mon, Oct 12, 2020 at 7:12 AM chenjiajun wrote: > > > > On 2020/10/2 10:05, Raphael Norwitz wrote: > > On Mon, Sep 28, 2020 at 9:17 AM Jiajun Chen wrote: > >> > >> Used_memslots is equal to dev->mem->nregions now, it is true for > >> vhost kernel, but not for vhost user, which uses the memory r

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-13 Thread Raphael Norwitz
On Tue, Oct 6, 2020 at 5:48 AM Igor Mammedov wrote: > > On Mon, 28 Sep 2020 21:17:31 +0800 > Jiajun Chen wrote: > > > Used_memslots is equal to dev->mem->nregions now, it is true for > > vhost kernel, but not for vhost user, which uses the memory regions > > that have file descriptor. In fact, no

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-12 Thread chenjiajun
On 2020/10/2 10:05, Raphael Norwitz wrote: > On Mon, Sep 28, 2020 at 9:17 AM Jiajun Chen wrote: >> >> Used_memslots is equal to dev->mem->nregions now, it is true for >> vhost kernel, but not for vhost user, which uses the memory regions >> that have file descriptor. In fact, not all of the mem

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-06 Thread Igor Mammedov
On Mon, 28 Sep 2020 21:17:31 +0800 Jiajun Chen wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is useful

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-01 Thread Raphael Norwitz
On Mon, Sep 28, 2020 at 9:17 AM Jiajun Chen wrote: > > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is usefully

[PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-28 Thread Jiajun Chen
Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-14 Thread Raphael Norwitz
A few more comments mixed in below. Once these are addressed I'd support this change from the vhost-user side. We should get opinions from other maintainers though, particularly for the kernel backend and vhost-user-net changes. On Tue, Sep 8, 2020 at 2:11 AM Jiajun Chen wrote: > > Used_memslots

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-08 Thread Michael S. Tsirkin
+ Cc: Igor Mammedov + Cc: Marc-André Lureau who worked on this in the past. On Tue, Sep 08, 2020 at 02:11:41PM +0800, Jiajun Chen wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that h

[PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-07 Thread Jiajun Chen
Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-01 Thread Raphael Norwitz
I see how this fixes vhost_has_free_slot() to correctly determine whether or not regions can be added, but why are the used_memslots_exceeded variable and the used_memslots_is_exceeded() API needed? On Mon, Aug 10, 2020 at 9:44 PM Jiajun Chen wrote: > > Used_memslots is equal to dev->mem->nregion

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-08-27 Thread Michael S. Tsirkin
On Tue, Aug 11, 2020 at 09:43:43AM +0800, Jiajun Chen wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is u

[PATCH] vhost-user: add separate memslot counter for vhost-user

2020-08-10 Thread Jiajun Chen
Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-08-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200807094750.13404-1-chenjiaj...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH] vhost-user: add separate memslot counter for vhost-user

2020-08-07 Thread Jiajun Chen
Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-08-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200807081900.69156-1-chenjiaj...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH] vhost-user: add separate memslot counter for vhost-user

2020-08-07 Thread Jiajun Chen
Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s